Sign upLogin

jkawamoto/roadie

View on GitHub
Star
cloud/mock/queue_test.go

Summary

Maintainability
F
4 days
Test Coverage

File queue_test.go has 649 lines of code (exceeds 500 allowed). Consider refactoring.
Open

//
// cloud/mock/queue_test.go
//
// Copyright (c) 2016-2017 Junpei Kawamoto
//
Severity: Minor
Found in cloud/mock/queue_test.go - About 5 hrs to fix

    Function TestQueues has a Cognitive Complexity of 39 (exceeds 20 allowed). Consider refactoring.
    Open

    func TestQueues(t *testing.T) {

    var err error
    ctx := context.Background()
    m := NewQueueManager()
    Severity: Minor
    Found in cloud/mock/queue_test.go - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function TestDeleteTask has a Cognitive Complexity of 37 (exceeds 20 allowed). Consider refactoring.
    Open

    func TestDeleteTask(t *testing.T) {

    var err error
    ctx := context.Background()
    m := NewQueueManager()
    Severity: Minor
    Found in cloud/mock/queue_test.go - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function TestStop has a Cognitive Complexity of 35 (exceeds 20 allowed). Consider refactoring.
    Open

    func TestStop(t *testing.T) {

    var err error
    ctx := context.Background()
    m := NewQueueManager()
    Severity: Minor
    Found in cloud/mock/queue_test.go - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function TestQueues has 89 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func TestQueues(t *testing.T) {

    var err error
    ctx := context.Background()
    m := NewQueueManager()
    Severity: Major
    Found in cloud/mock/queue_test.go - About 2 hrs to fix

      Function TestDeleteTask has 84 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func TestDeleteTask(t *testing.T) {

    var err error
    ctx := context.Background()
    m := NewQueueManager()
      Severity: Major
      Found in cloud/mock/queue_test.go - About 2 hrs to fix

        Function TestWorkers has 74 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func TestWorkers(t *testing.T) {

    var err error
    ctx := context.Background()
    m := NewQueueManager()
        Severity: Minor
        Found in cloud/mock/queue_test.go - About 1 hr to fix

          Function TestRestart has 69 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func TestRestart(t *testing.T) {

    var err error
    ctx := context.Background()
    m := NewQueueManager()
          Severity: Minor
          Found in cloud/mock/queue_test.go - About 1 hr to fix

            Function TestRestart has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
            Open

            func TestRestart(t *testing.T) {

    var err error
    ctx := context.Background()
    m := NewQueueManager()
            Severity: Minor
            Found in cloud/mock/queue_test.go - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function TestCreateWorkers has 65 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func TestCreateWorkers(t *testing.T) {

    var err error
    ctx := context.Background()
    m := NewQueueManager()
            Severity: Minor
            Found in cloud/mock/queue_test.go - About 1 hr to fix

              Function TestTasks has 63 lines of code (exceeds 50 allowed). Consider refactoring.
              Open

              func TestTasks(t *testing.T) {

    var err error
    ctx := context.Background()
    m := NewQueueManager()
              Severity: Minor
              Found in cloud/mock/queue_test.go - About 1 hr to fix

                Function TestEnqueue has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
                Open

                func TestEnqueue(t *testing.T) {

    ctx := context.Background()
    m := NewQueueManager()
                Severity: Minor
                Found in cloud/mock/queue_test.go - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function TestStop has 58 lines of code (exceeds 50 allowed). Consider refactoring.
                Open

                func TestStop(t *testing.T) {

    var err error
    ctx := context.Background()
    m := NewQueueManager()
                Severity: Minor
                Found in cloud/mock/queue_test.go - About 1 hr to fix

                  Function TestWorkers has 6 return statements (exceeds 4 allowed).
                  Open

                  func TestWorkers(t *testing.T) {

    var err error
    ctx := context.Background()
    m := NewQueueManager()
                  Severity: Major
                  Found in cloud/mock/queue_test.go - About 40 mins to fix

                    Function TestCreateWorkers has 5 return statements (exceeds 4 allowed).
                    Open

                    func TestCreateWorkers(t *testing.T) {

    var err error
    ctx := context.Background()
    m := NewQueueManager()
                    Severity: Major
                    Found in cloud/mock/queue_test.go - About 35 mins to fix

                      Function TestQueues has 5 return statements (exceeds 4 allowed).
                      Open

                      func TestQueues(t *testing.T) {

    var err error
    ctx := context.Background()
    m := NewQueueManager()
                      Severity: Major
                      Found in cloud/mock/queue_test.go - About 35 mins to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            t.Run("delete the last task", func(t *testing.T) {
        err = m.DeleteTask(ctx, indexedName(queueBase, 2), indexedName(task.Name, 2))
        if err != nil {
            t.Fatalf("DeleteTasks returns an error: %v", err)
        }
                        Severity: Major
                        Found in cloud/mock/queue_test.go and 1 other location - About 1 hr to fix
                        cloud/mock/queue_test.go on lines 727..737

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 139.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            t.Run("delete the first task", func(t *testing.T) {
        err = m.DeleteTask(ctx, indexedName(queueBase, 5), indexedName(task.Name, 0))
        if err != nil {
            t.Fatalf("DeleteTasks returns an error: %v", err)
        }
                        Severity: Major
                        Found in cloud/mock/queue_test.go and 1 other location - About 1 hr to fix
                        cloud/mock/queue_test.go on lines 739..749

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 139.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            t.Run("out-of-service queue manager", func(t *testing.T) {
        m.Failure = true
        defer func() { m.Failure = false }()
        err = m.Stop(ctx, indexedName(queueBase, 0))
        if err != ErrServiceFailure {
                        Severity: Minor
                        Found in cloud/mock/queue_test.go and 1 other location - About 35 mins to fix
                        cloud/mock/queue_test.go on lines 662..670

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 103.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            t.Run("out-of-service queue manager", func(t *testing.T) {
        m.Failure = true
        defer func() { m.Failure = false }()

        err = m.DeleteQueue(ctx, indexedName(queueBase, 5))
                        Severity: Minor
                        Found in cloud/mock/queue_test.go and 1 other location - About 35 mins to fix
                        cloud/mock/queue_test.go on lines 355..362

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 103.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status