Sign upLogin

jkawamoto/roadie

View on GitHub
Star
command/config_test.go

Summary

Maintainability
F
5 days
Test Coverage

Function TestCmdConfigMachineTypeList has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
Open

func TestCmdConfigMachineTypeList(t *testing.T) {

    var err error
    var output bytes.Buffer
    p := mock.NewProvider()
Severity: Minor
Found in command/config_test.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function TestCmdConfigRegionList has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
Open

func TestCmdConfigRegionList(t *testing.T) {

    var err error
    var output bytes.Buffer
    p := mock.NewProvider()
Severity: Minor
Found in command/config_test.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function TestConfigMachineTypeSet has 56 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TestConfigMachineTypeSet(t *testing.T) {

    var err error
    var output bytes.Buffer
    p := mock.NewProvider()
Severity: Minor
Found in command/config_test.go - About 1 hr to fix

    Function TestConfigRegionSet has 56 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func TestConfigRegionSet(t *testing.T) {

    var err error
    var output bytes.Buffer
    p := mock.NewProvider()
    Severity: Minor
    Found in command/config_test.go - About 1 hr to fix

      Function TestCmdConfigProjectSet has 51 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func TestCmdConfigProjectSet(t *testing.T) {

    var err error
    var output bytes.Buffer
    p := mock.NewProvider()
      Severity: Minor
      Found in command/config_test.go - About 1 hr to fix

        Function TestCmdConfigMachineTypeList has 51 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func TestCmdConfigMachineTypeList(t *testing.T) {

    var err error
    var output bytes.Buffer
    p := mock.NewProvider()
        Severity: Minor
        Found in command/config_test.go - About 1 hr to fix

          Function TestCmdConfigRegionList has 51 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func TestCmdConfigRegionList(t *testing.T) {

    var err error
    var output bytes.Buffer
    p := mock.NewProvider()
          Severity: Minor
          Found in command/config_test.go - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func TestConfigMachineTypeSet(t *testing.T) {

    var err error
    var output bytes.Buffer
    p := mock.NewProvider()
            Severity: Major
            Found in command/config_test.go and 1 other location - About 1 day to fix
            command/config_test.go on lines 321..389

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 637.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func TestConfigRegionSet(t *testing.T) {

    var err error
    var output bytes.Buffer
    p := mock.NewProvider()
            Severity: Major
            Found in command/config_test.go and 1 other location - About 1 day to fix
            command/config_test.go on lines 151..218

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 637.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                t.Run(fmt.Sprintf("region=%q", "region A"), func(t *testing.T) {
        defer output.Reset()

        err = cmdConfigRegionList(m)
        if err != nil {
            Severity: Major
            Found in command/config_test.go and 1 other location - About 4 hrs to fix
            command/config_test.go on lines 229..260

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 323.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                t.Run("type A", func(t *testing.T) {
        defer output.Reset()

        err = cmdConfigMachineTypeList(m)
        if err != nil {
            Severity: Major
            Found in command/config_test.go and 1 other location - About 4 hrs to fix
            command/config_test.go on lines 400..431

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 323.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func TestCmdConfigMachineTypeShow(t *testing.T) {

    var err error
    var output bytes.Buffer
    p := mock.NewProvider()
            Severity: Major
            Found in command/config_test.go and 1 other location - About 3 hrs to fix
            command/config_test.go on lines 453..490

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 288.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func TestCmdConfigRegionShow(t *testing.T) {

    var err error
    var output bytes.Buffer
    p := mock.NewProvider()
            Severity: Major
            Found in command/config_test.go and 1 other location - About 3 hrs to fix
            command/config_test.go on lines 282..319

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 288.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status