Sign upLogin

jkawamoto/roadie

View on GitHub
Star
command/queue.go

Summary

Maintainability
B
6 hrs
Test Coverage

Function cmdQueueAdd has 5 return statements (exceeds 4 allowed).
Open

func cmdQueueAdd(opt *optQueueAdd) (err error) {

    s, err := script.NewScriptWithArgs(opt.ScriptFile, opt.ScriptArgs)
    if err != nil {
        return
Severity: Major
Found in command/queue.go - About 35 mins to fix

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    func CmdQueueStop(c *cli.Context) (err error) {

    if c.NArg() != 1 {
        fmt.Printf("expected 1 argument. (%d given)\n", c.NArg())
        return cli.ShowSubcommandHelp(c)
    Severity: Major
    Found in command/queue.go and 5 other locations - About 1 hr to fix
    command/config.go on lines 51..69
    command/config.go on lines 145..162
    command/config.go on lines 292..309
    command/queue.go on lines 309..326
    command/queue.go on lines 417..434

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 156.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    func CmdQueueInstanceList(c *cli.Context) (err error) {

    if c.NArg() != 1 {
        fmt.Printf("expected 1 argument. (%d given)\n", c.NArg())
        return cli.ShowSubcommandHelp(c)
    Severity: Major
    Found in command/queue.go and 5 other locations - About 1 hr to fix
    command/config.go on lines 51..69
    command/config.go on lines 145..162
    command/config.go on lines 292..309
    command/queue.go on lines 385..403
    command/queue.go on lines 417..434

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 156.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    func CmdQueueRestart(c *cli.Context) (err error) {

    if c.NArg() != 1 {
        fmt.Printf("expected 1 argument. (%d given)\n", c.NArg())
        return cli.ShowSubcommandHelp(c)
    Severity: Major
    Found in command/queue.go and 5 other locations - About 1 hr to fix
    command/config.go on lines 51..69
    command/config.go on lines 145..162
    command/config.go on lines 292..309
    command/queue.go on lines 309..326
    command/queue.go on lines 385..403

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 156.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        return log.GetQueueLog(m.Context, queue, func(t time.Time, line string, stderr bool) (err error) {
        var msg string
        if timestamp {
            msg = fmt.Sprintf("%v %s", t.Format(PrintTimeFormat), line)
        } else {
    Severity: Minor
    Found in command/queue.go and 1 other location - About 55 mins to fix
    command/queue.go on lines 292..305

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 124.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        return log.GetTaskLog(m.Context, queue, task, func(t time.Time, line string, stderr bool) (err error) {
        var msg string
        if timestamp {
            msg = fmt.Sprintf("%v %s", t.Format(PrintTimeFormat), line)
        } else {
    Severity: Minor
    Found in command/queue.go and 1 other location - About 55 mins to fix
    command/queue.go on lines 270..283

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 124.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status