Sign upLogin

jkawamoto/roadie

View on GitHub
Star

Showing 2,161 of 2,161 total issues

Similar blocks of code found in 9 locations. Consider refactoring.
Open

func (a *Client) ResourcesCreateOrUpdate(params *ResourcesCreateOrUpdateParams, authInfo runtime.ClientAuthInfoWriter) (*ResourcesCreateOrUpdateOK, *ResourcesCreateOrUpdateCreated, *ResourcesCreateOrUpdateAccepted, error) {
    // TODO: Validate the params before sending
    if params == nil {
        params = NewResourcesCreateOrUpdateParams()
    }
Severity: Major
Found in cloud/azure/resource/client/resources/resources_client.go and 8 other locations - About 3 hrs to fix
cloud/azure/compute/client/images/images_client.go on lines 63..95
cloud/azure/compute/client/virtual_machine_extensions/virtual_machine_extensions_client.go on lines 63..95
cloud/azure/compute/client/virtual_machine_scale_set_vms/virtual_machine_scale_set_vms_client.go on lines 63..95
cloud/azure/compute/client/virtual_machine_scale_sets/virtual_machine_scale_sets_client.go on lines 98..130
cloud/azure/compute/client/virtual_machines/virtual_machines_client.go on lines 168..200
cloud/azure/resource/client/resources/resources_client.go on lines 123..155
cloud/azure/resource/client/resources/resources_client.go on lines 160..192
cloud/azure/resource/client/resources/resources_client.go on lines 197..229

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 271.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

func (a *Client) VirtualMachineScaleSetsDelete(params *VirtualMachineScaleSetsDeleteParams, authInfo runtime.ClientAuthInfoWriter) (*VirtualMachineScaleSetsDeleteOK, *VirtualMachineScaleSetsDeleteAccepted, *VirtualMachineScaleSetsDeleteNoContent, error) {
    // TODO: Validate the params before sending
    if params == nil {
        params = NewVirtualMachineScaleSetsDeleteParams()
    }
Severity: Major
Found in cloud/azure/compute/client/virtual_machine_scale_sets/virtual_machine_scale_sets_client.go and 8 other locations - About 3 hrs to fix
cloud/azure/compute/client/images/images_client.go on lines 63..95
cloud/azure/compute/client/virtual_machine_extensions/virtual_machine_extensions_client.go on lines 63..95
cloud/azure/compute/client/virtual_machine_scale_set_vms/virtual_machine_scale_set_vms_client.go on lines 63..95
cloud/azure/compute/client/virtual_machines/virtual_machines_client.go on lines 168..200
cloud/azure/resource/client/resources/resources_client.go on lines 86..118
cloud/azure/resource/client/resources/resources_client.go on lines 123..155
cloud/azure/resource/client/resources/resources_client.go on lines 160..192
cloud/azure/resource/client/resources/resources_client.go on lines 197..229

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 271.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

func (a *Client) ImagesDelete(params *ImagesDeleteParams, authInfo runtime.ClientAuthInfoWriter) (*ImagesDeleteOK, *ImagesDeleteAccepted, *ImagesDeleteNoContent, error) {
    // TODO: Validate the params before sending
    if params == nil {
        params = NewImagesDeleteParams()
    }
Severity: Major
Found in cloud/azure/compute/client/images/images_client.go and 8 other locations - About 3 hrs to fix
cloud/azure/compute/client/virtual_machine_extensions/virtual_machine_extensions_client.go on lines 63..95
cloud/azure/compute/client/virtual_machine_scale_set_vms/virtual_machine_scale_set_vms_client.go on lines 63..95
cloud/azure/compute/client/virtual_machine_scale_sets/virtual_machine_scale_sets_client.go on lines 98..130
cloud/azure/compute/client/virtual_machines/virtual_machines_client.go on lines 168..200
cloud/azure/resource/client/resources/resources_client.go on lines 86..118
cloud/azure/resource/client/resources/resources_client.go on lines 123..155
cloud/azure/resource/client/resources/resources_client.go on lines 160..192
cloud/azure/resource/client/resources/resources_client.go on lines 197..229

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 271.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

func (a *Client) ResourcesDeleteByID(params *ResourcesDeleteByIDParams, authInfo runtime.ClientAuthInfoWriter) (*ResourcesDeleteByIDOK, *ResourcesDeleteByIDAccepted, *ResourcesDeleteByIDNoContent, error) {
    // TODO: Validate the params before sending
    if params == nil {
        params = NewResourcesDeleteByIDParams()
    }
Severity: Major
Found in cloud/azure/resource/client/resources/resources_client.go and 8 other locations - About 3 hrs to fix
cloud/azure/compute/client/images/images_client.go on lines 63..95
cloud/azure/compute/client/virtual_machine_extensions/virtual_machine_extensions_client.go on lines 63..95
cloud/azure/compute/client/virtual_machine_scale_set_vms/virtual_machine_scale_set_vms_client.go on lines 63..95
cloud/azure/compute/client/virtual_machine_scale_sets/virtual_machine_scale_sets_client.go on lines 98..130
cloud/azure/compute/client/virtual_machines/virtual_machines_client.go on lines 168..200
cloud/azure/resource/client/resources/resources_client.go on lines 86..118
cloud/azure/resource/client/resources/resources_client.go on lines 123..155
cloud/azure/resource/client/resources/resources_client.go on lines 160..192

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 271.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method mockStorageAccountServer.ServeHTTP has 107 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (m *mockStorageAccountServer) ServeHTTP(res http.ResponseWriter, req *http.Request) {

    paths := strings.Split(strings.TrimPrefix(req.URL.Path, "/"), "/")
    if len(paths) < 2 {
        res.WriteHeader(http.StatusBadRequest)
Severity: Major
Found in cloud/azure/storage_test.go - About 3 hrs to fix

    PoolEnableAutoScaleParams has 27 methods (exceeds 20 allowed). Consider refactoring.
    Open

    type PoolEnableAutoScaleParams struct {

    /*IfMatch
      An ETag is specified. Specify this header to perform the operation only if the resource's ETag is an exact match as specified.
    Severity: Minor
    Found in cloud/azure/batch/client/pools/pool_enable_auto_scale_parameters.go - About 3 hrs to fix

      PoolPatchParams has 27 methods (exceeds 20 allowed). Consider refactoring.
      Open

      type PoolPatchParams struct {

    /*IfMatch
      An ETag is specified. Specify this header to perform the operation only if the resource's ETag is an exact match as specified.
      Severity: Minor
      Found in cloud/azure/batch/client/pools/pool_patch_parameters.go - About 3 hrs to fix

        PoolResizeParams has 27 methods (exceeds 20 allowed). Consider refactoring.
        Open

        type PoolResizeParams struct {

    /*IfMatch
      An ETag is specified. Specify this header to perform the operation only if the resource's ETag is an exact match as specified.
        Severity: Minor
        Found in cloud/azure/batch/client/pools/pool_resize_parameters.go - About 3 hrs to fix

          PoolUpgradeOSParams has 27 methods (exceeds 20 allowed). Consider refactoring.
          Open

          type PoolUpgradeOSParams struct {

    /*IfMatch
      An ETag is specified. Specify this header to perform the operation only if the resource's ETag is an exact match as specified.
          Severity: Minor
          Found in cloud/azure/batch/client/pools/pool_upgrade_o_s_parameters.go - About 3 hrs to fix

            JobUpdateParams has 27 methods (exceeds 20 allowed). Consider refactoring.
            Open

            type JobUpdateParams struct {

    /*IfMatch
      An ETag is specified. Specify this header to perform the operation only if the resource's ETag is an exact match as specified.
            Severity: Minor
            Found in cloud/azure/batch/client/jobs/job_update_parameters.go - About 3 hrs to fix

              TaskReactivateParams has 27 methods (exceeds 20 allowed). Consider refactoring.
              Open

              type TaskReactivateParams struct {

    /*IfMatch
      An ETag is specified. Specify this header to perform the operation only if the resource's ETag is an exact match as specified.
              Severity: Minor
              Found in cloud/azure/batch/client/tasks/task_reactivate_parameters.go - About 3 hrs to fix

                JobDisableParams has 27 methods (exceeds 20 allowed). Consider refactoring.
                Open

                type JobDisableParams struct {

    /*IfMatch
      An ETag is specified. Specify this header to perform the operation only if the resource's ETag is an exact match as specified.
                Severity: Minor
                Found in cloud/azure/batch/client/jobs/job_disable_parameters.go - About 3 hrs to fix

                  JobScheduleUpdateParams has 27 methods (exceeds 20 allowed). Consider refactoring.
                  Open

                  type JobScheduleUpdateParams struct {

    /*IfMatch
      An ETag is specified. Specify this header to perform the operation only if the resource's ETag is an exact match as specified.
                  Severity: Minor
                  Found in cloud/azure/batch/client/job_schedules/job_schedule_update_parameters.go - About 3 hrs to fix

                    JobTerminateParams has 27 methods (exceeds 20 allowed). Consider refactoring.
                    Open

                    type JobTerminateParams struct {

    /*IfMatch
      An ETag is specified. Specify this header to perform the operation only if the resource's ETag is an exact match as specified.
                    Severity: Minor
                    Found in cloud/azure/batch/client/jobs/job_terminate_parameters.go - About 3 hrs to fix

                      PoolRemoveNodesParams has 27 methods (exceeds 20 allowed). Consider refactoring.
                      Open

                      type PoolRemoveNodesParams struct {

    /*IfMatch
      An ETag is specified. Specify this header to perform the operation only if the resource's ETag is an exact match as specified.
                      Severity: Minor
                      Found in cloud/azure/batch/client/compute_nodes/pool_remove_nodes_parameters.go - About 3 hrs to fix

                        JobPatchParams has 27 methods (exceeds 20 allowed). Consider refactoring.
                        Open

                        type JobPatchParams struct {

    /*IfMatch
      An ETag is specified. Specify this header to perform the operation only if the resource's ETag is an exact match as specified.
                        Severity: Minor
                        Found in cloud/azure/batch/client/jobs/job_patch_parameters.go - About 3 hrs to fix

                          TaskDeleteParams has 27 methods (exceeds 20 allowed). Consider refactoring.
                          Open

                          type TaskDeleteParams struct {

    /*IfMatch
      An ETag is specified. Specify this header to perform the operation only if the resource's ETag is an exact match as specified.
                          Severity: Minor
                          Found in cloud/azure/batch/client/tasks/task_delete_parameters.go - About 3 hrs to fix

                            TaskTerminateParams has 27 methods (exceeds 20 allowed). Consider refactoring.
                            Open

                            type TaskTerminateParams struct {

    /*IfMatch
      An ETag is specified. Specify this header to perform the operation only if the resource's ETag is an exact match as specified.
                            Severity: Minor
                            Found in cloud/azure/batch/client/tasks/task_terminate_parameters.go - About 3 hrs to fix

                              JobSchedulePatchParams has 27 methods (exceeds 20 allowed). Consider refactoring.
                              Open

                              type JobSchedulePatchParams struct {

    /*IfMatch
      An ETag is specified. Specify this header to perform the operation only if the resource's ETag is an exact match as specified.
                              Severity: Minor
                              Found in cloud/azure/batch/client/job_schedules/job_schedule_patch_parameters.go - About 3 hrs to fix

                                FileGetFromComputeNodeParams has 27 methods (exceeds 20 allowed). Consider refactoring.
                                Open

                                type FileGetFromComputeNodeParams struct {

    /*IfModifiedSince
      Specify this header to perform the operation only if the resource has been modified since the specified date/time.
                                Severity: Minor
                                Found in cloud/azure/batch/client/files/file_get_from_compute_node_parameters.go - About 3 hrs to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language