jkawamoto/roadie

View on GitHub

Showing 2,161 of 2,161 total issues

Method ComputeNodeAddUserParams.WriteToRequest has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
Open

func (o *ComputeNodeAddUserParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    r.SetTimeout(o.requestTimeout)
    var res []error

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ComputeNodeListParams.WriteToRequest has 11 return statements (exceeds 4 allowed).
Open

func (o *ComputeNodeListParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    r.SetTimeout(o.requestTimeout)
    var res []error

    Method ComputeNodeReimageParams.WriteToRequest has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
    Open

    func (o *ComputeNodeReimageParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {
    
        r.SetTimeout(o.requestTimeout)
        var res []error
    
    

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method JobListParams.WriteToRequest has 11 return statements (exceeds 4 allowed).
    Open

    func (o *JobListParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {
    
        r.SetTimeout(o.requestTimeout)
        var res []error
    
    
    Severity: Major
    Found in cloud/azure/batch/client/jobs/job_list_parameters.go - About 1 hr to fix

      Method ComputeNodeDisableSchedulingParams.WriteToRequest has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
      Open

      func (o *ComputeNodeDisableSchedulingParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {
      
          r.SetTimeout(o.requestTimeout)
          var res []error
      
      

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method JobScheduleListParams.WriteToRequest has 11 return statements (exceeds 4 allowed).
      Open

      func (o *JobScheduleListParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {
      
          r.SetTimeout(o.requestTimeout)
          var res []error
      
      

        Method FileDeleteFromComputeNodeParams.WriteToRequest has 11 return statements (exceeds 4 allowed).
        Open

        func (o *FileDeleteFromComputeNodeParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {
        
            r.SetTimeout(o.requestTimeout)
            var res []error
        
        

          Method FileDeleteFromTaskParams.WriteToRequest has 11 return statements (exceeds 4 allowed).
          Open

          func (o *FileDeleteFromTaskParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {
          
              r.SetTimeout(o.requestTimeout)
              var res []error
          
          
          Severity: Major
          Found in cloud/azure/batch/client/files/file_delete_from_task_parameters.go - About 1 hr to fix

            Method ResourcesCreateOrUpdateParams.WriteToRequest has 11 return statements (exceeds 4 allowed).
            Open

            func (o *ResourcesCreateOrUpdateParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {
            
                if err := r.SetTimeout(o.timeout); err != nil {
                    return err
                }

              Method LogManager.Delete has 11 return statements (exceeds 4 allowed).
              Open

              func (m *LogManager) Delete(ctx context.Context, instanceName string) (err error) {
              
                  var loc *url.URL
                  // Delete a config file for initialization.
                  loc, err = url.Parse(script.RoadieSchemePrefix + StartupContainer)
              Severity: Major
              Found in cloud/azure/log_manager.go - About 1 hr to fix

                Function TestLogManagerGet has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
                Open

                func TestLogManagerGet(t *testing.T) {
                
                    var err error
                    server := mock.NewStorageServer()
                    defer server.Close()
                Severity: Minor
                Found in cloud/azure/log_manager_test.go - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method VirtualMachineImagesListParams.WriteToRequest has 11 return statements (exceeds 4 allowed).
                Open

                func (o *VirtualMachineImagesListParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {
                
                    r.SetTimeout(o.timeout)
                    var res []error
                
                

                  Function Archive has 52 lines of code (exceeds 50 allowed). Consider refactoring.
                  Open

                  func Archive(root string, filename string, excludes []string) (err error) {
                  
                      writeFile, err := os.OpenFile(filename, os.O_WRONLY|os.O_CREATE, 0600)
                      if err != nil {
                          return
                  Severity: Minor
                  Found in command/util/archive.go - About 1 hr to fix

                    Method ApplicationListParams.WriteToRequest has 52 lines of code (exceeds 50 allowed). Consider refactoring.
                    Open

                    func (o *ApplicationListParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {
                    
                        r.SetTimeout(o.requestTimeout)
                        var res []error
                    
                    

                      Method ComputeNodeAddUserParams.WriteToRequest has 52 lines of code (exceeds 50 allowed). Consider refactoring.
                      Open

                      func (o *ComputeNodeAddUserParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {
                      
                          r.SetTimeout(o.requestTimeout)
                          var res []error
                      
                      

                        Method ComputeNodeDisableSchedulingParams.WriteToRequest has 52 lines of code (exceeds 50 allowed). Consider refactoring.
                        Open

                        func (o *ComputeNodeDisableSchedulingParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {
                        
                            r.SetTimeout(o.requestTimeout)
                            var res []error
                        
                        

                          Method ComputeNodeReimageParams.WriteToRequest has 52 lines of code (exceeds 50 allowed). Consider refactoring.
                          Open

                          func (o *ComputeNodeReimageParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {
                          
                              r.SetTimeout(o.requestTimeout)
                              var res []error
                          
                          

                            Method ComputeNodeRebootParams.WriteToRequest has 52 lines of code (exceeds 50 allowed). Consider refactoring.
                            Open

                            func (o *ComputeNodeRebootParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {
                            
                                r.SetTimeout(o.requestTimeout)
                                var res []error
                            
                            

                              Method LogManager.get has 52 lines of code (exceeds 50 allowed). Consider refactoring.
                              Open

                              func (m *LogManager) get(ctx context.Context, urls []*url.URL, handler cloud.LogHandler) (err error) {
                              
                                  ch := make(chan string)
                                  wg, ctx := errgroup.WithContext(ctx)
                                  reader, writer := io.Pipe()
                              Severity: Minor
                              Found in cloud/azure/log_manager.go - About 1 hr to fix

                                Function TestGetQueueLog has 52 lines of code (exceeds 50 allowed). Consider refactoring.
                                Open

                                func TestGetQueueLog(t *testing.T) {
                                
                                    m := NewLogManager()
                                    now := time.Now()
                                    queue := "test-queue"
                                Severity: Minor
                                Found in cloud/mock/log_test.go - About 1 hr to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language