Sign upLogin

jkphl/micrometa

View on GitHub
Star
src/Micrometa/Infrastructure/Parser/JsonLD.php

Summary

Maintainability
A
0 mins
Test Coverage
A
97%

The class JsonLD has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13.
Open

class JsonLD extends AbstractParser
{
    /**
     * Format
     *
Severity: Minor
Found in src/Micrometa/Infrastructure/Parser/JsonLD.php by phpmd

CouplingBetweenObjects

Since: 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

Example

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Source https://phpmd.org/rules/design.html#couplingbetweenobjects

Missing class import via use statement (line '116', column '53').
Open

        $this->logger->info('Running parser: '.(new \ReflectionClass(__CLASS__))->getShortName());
Severity: Minor
Found in src/Micrometa/Infrastructure/Parser/JsonLD.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Remove error control operator '@' on line 146.
Open

    protected function parseDocument($jsonLDDocSource)
    {
        $jsonLDDocSource = $this->sanitizeJsonSource($jsonLDDocSource);

        // Unserialize the JSON-LD document
Severity: Minor
Found in src/Micrometa/Infrastructure/Parser/JsonLD.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Missing class import via use statement (line '120', column '27').
Open

        $xpath      = new \DOMXPath($dom);
Severity: Minor
Found in src/Micrometa/Infrastructure/Parser/JsonLD.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid variables with short names like $i. Configured minimum length is 3.
Open

            $i               = $this->parseDocument($jsonLDDocSource);
Severity: Minor
Found in src/Micrometa/Infrastructure/Parser/JsonLD.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

There are no issues that match your filters.

Category
Status