Sign upLogin

jkuchar/FileDownloader

View on GitHub
Star
src/AdvancedDownloader.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method start has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function start(FileDownload $file, IRequest $request, IResponse $response) {
        if(!$this->isCompatible($file)) {
            throw new DownloaderNotSupported('Please check you P');
        }
Severity: Major
Found in src/AdvancedDownloader.php - About 2 hrs to fix

    Function start has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public function start(FileDownload $file, IRequest $request, IResponse $response) {
        if(!$this->isCompatible($file)) {
            throw new DownloaderNotSupported('Please check you P');
        }
    Severity: Minor
    Found in src/AdvancedDownloader.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parseRequest has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function parseRequest(IRequest $request, IResponse $response)
    {
        $this->length = $this->size; // Content-length
        $this->start = 0;
        $this->end = $this->size - 1;
    Severity: Minor
    Found in src/AdvancedDownloader.php - About 1 hr to fix

      Function parseRequest has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          private function parseRequest(IRequest $request, IResponse $response)
    {
        $this->length = $this->size; // Content-length
        $this->start = 0;
        $this->end = $this->size - 1;
      Severity: Minor
      Found in src/AdvancedDownloader.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status