jlawrence11/eos

View on GitHub
src/Matrix.php

Summary

Maintainability
D
2 days
Test Coverage

File Matrix.php has 339 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * matrix.class.php
 *
 * Will set up the defines for error checking as well as provide
Severity: Minor
Found in src/Matrix.php - About 4 hrs to fix

    Function coFactor has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

        public function coFactor($cArray=false,$asArray=true)
        {
            if(!$cArray) $cArray = $this->matrix;
            if(!$this->isSquare($cArray))
                throw new \Exception("'{$this}' is not a square matrix", Matrix::E_NOT_SQUARE);
    Severity: Minor
    Found in src/Matrix.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getDeterminant has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getDeterminant($mArray = false)
        {
            if(!$mArray) $mArray = $this->matrix;
            //print_r($mArray);
            if(!$this->isSquare($mArray))
    Severity: Minor
    Found in src/Matrix.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method coFactor has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function coFactor($cArray=false,$asArray=true)
        {
            if(!$cArray) $cArray = $this->matrix;
            if(!$this->isSquare($cArray))
                throw new \Exception("'{$this}' is not a square matrix", Matrix::E_NOT_SQUARE);
    Severity: Minor
    Found in src/Matrix.php - About 1 hr to fix

      Function _verify has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          private function _verify($mArray = false)
          {
              if(!$mArray) $mArray = $this->matrix;
              $nSet = false;
              
      Severity: Minor
      Found in src/Matrix.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getDeterminant has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getDeterminant($mArray = false)
          {
              if(!$mArray) $mArray = $this->matrix;
              //print_r($mArray);
              if(!$this->isSquare($mArray))
      Severity: Minor
      Found in src/Matrix.php - About 1 hr to fix

        Function createIdentity has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function createIdentity($n, $useInternal = true)
            {
                $mArray = array();
                for($rows=0;$rows<$n;$rows++) {
                    for($cols=0;$cols<$n;$cols++) {
        Severity: Minor
        Found in src/Matrix.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function mpMatrix has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function mpMatrix(Matrix $bMatrix)
            {
                if(!$this->_verify() || !$bMatrix->_verify()) {
                    // @codeCoverageIgnoreStart
                    // Should never get this far
        Severity: Minor
        Found in src/Matrix.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                                if($jj==$j) {
                                    continue;
                                }
        Severity: Major
        Found in src/Matrix.php - About 45 mins to fix

          Function transpose has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function transpose($cArray=false,$asArray=true)
              {
                  if(!$cArray) $cArray = $this->matrix;
                  if(!$this->isSquare($cArray))
                      throw new \Exception("'{$this}' is not a square matrix", Matrix::E_NOT_SQUARE);
          Severity: Minor
          Found in src/Matrix.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function addMatrix has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function addMatrix(Matrix $nMatrix)
              {
                  if(!$this->_verify() || !$nMatrix->_verify())
                      throw new \Exception("Matrices have varying column sizes", Matrix::E_INVALID_MATRIX);
          
          
          Severity: Minor
          Found in src/Matrix.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function subMatrix has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function subMatrix(Matrix $nMatrix)
              {
                  if(!$this->_verify() || !$nMatrix->_verify())
                      throw new \Exception("Matrices have varying column sizes", Matrix::E_INVALID_MATRIX);
          
          
          Severity: Minor
          Found in src/Matrix.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if((count($matrix1)!=count($matrix2)) || (count($matrix1[0])!=count($matrix2[0])))
                  {
                      $m1 = $this->toString($matrix1);
                      $m2 = $this->toString($matrix2);
                      throw new \Exception("The rows and/or columns '{$m1}' and '{$m2}' are not the same", Matrix::E_NOT_EQUAL);
          Severity: Major
          Found in src/Matrix.php and 1 other location - About 1 hr to fix
          src/Matrix.php on lines 343..348

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 101.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if((count($matrix1)!=count($matrix2)) || (count($matrix1[0])!=count($matrix2[0])))
                  {
                      $m1 = $this->toString($matrix1);
                      $m2 = $this->toString($matrix2);
                      throw new \Exception("The rows and/or columns '{$m1}' and '{$m2}' are not the same", Matrix::E_NOT_EQUAL);
          Severity: Major
          Found in src/Matrix.php and 1 other location - About 1 hr to fix
          src/Matrix.php on lines 378..383

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 101.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status