Sign upLogin

jmarca/initial-solution

View on GitHub
Star
src/breaks.py

Summary

Maintainability
A
2 hrs
Test Coverage
A
95%

Function split_links_break_nodes has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

def split_links_break_nodes(O,D,travel_time,new_node,break_time,reset_time):
Severity: Minor
Found in src/breaks.py - About 45 mins to fix

    Function make_nodes has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def make_nodes(O,D,travel_time,starting_node,timelength=60):
    """starting with O, ending with D, make a dummy node every timelength minutes
    arguments: O: origin node, integer
               D: destination node, integer
               travel_time: time from O to D, in minutes
    Severity: Minor
    Found in src/breaks.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function make_nodes has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def make_nodes(O,D,travel_time,starting_node,timelength=60):
    Severity: Minor
    Found in src/breaks.py - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status