jmarca/initial-solution

View on GitHub
src/model_run.py

Summary

Maintainability
B
4 hrs
Test Coverage
B
84%

Function model_run has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

def model_run(d,t,v,base_value,
Severity: Major
Found in src/model_run.py - About 50 mins to fix

    Function breaks_at_nodes_constraints has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def breaks_at_nodes_constraints(d,
    Severity: Minor
    Found in src/model_run.py - About 45 mins to fix

      Function model_run_nobreaks has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def model_run_nobreaks(d,t,v,demand_subset=None,initial_routes=None,args=None):
      Severity: Minor
      Found in src/model_run.py - About 45 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            droppable_nodes = [routing.AddDisjunction([manager.NodeToIndex(c)],
                                                      penalty) for c in d.get_node_list()]
        Severity: Minor
        Found in src/model_run.py and 1 other location - About 30 mins to fix
        src/model_run.py on lines 302..303

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                time_dimension.CumulVar(index).SetRange(vehicle.time_window[0],
                                                        vehicle.time_window[1])
        Severity: Minor
        Found in src/model_run.py and 1 other location - About 30 mins to fix
        src/model_run.py on lines 242..243

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                time_dimension.CumulVar(index).SetRange(vehicle.time_window[0],
                                                        vehicle.time_window[1])
        Severity: Minor
        Found in src/model_run.py and 1 other location - About 30 mins to fix
        src/model_run.py on lines 230..231

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            droppable_nodes = [routing.AddDisjunction([manager.NodeToIndex(c)],
                                                      penalty) for c in d.get_node_list()]
        Severity: Minor
        Found in src/model_run.py and 1 other location - About 30 mins to fix
        src/model_run.py on lines 345..346

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status