Sign upLogin

jnidzwetzki/bboxdb

View on GitHub
Star

Showing 202 of 966 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

/*******************************************************************************
 *
 *    Copyright (C) 2015-2022 the BBoxDB project
 *  
 *    Licensed under the Apache License, Version 2.0 (the "License");
Severity: Major
Found in bboxdb-tools/src/main/java/org/bboxdb/tools/converter/osm/store/OSMJDBCDerbyNodeStore.java and 1 other location - About 1 day to fix
bboxdb-tools/src/main/java/org/bboxdb/tools/converter/osm/store/OSMJDBCH2NodeStore.java on lines 1..190

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 598.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

/*******************************************************************************
 *
 *    Copyright (C) 2015-2022 the BBoxDB project
 *  
 *    Licensed under the Apache License, Version 2.0 (the "License");
Severity: Major
Found in bboxdb-tools/src/main/java/org/bboxdb/tools/converter/osm/store/OSMJDBCH2NodeStore.java and 1 other location - About 1 day to fix
bboxdb-tools/src/main/java/org/bboxdb/tools/converter/osm/store/OSMJDBCDerbyNodeStore.java on lines 1..190

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 598.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 12 locations. Consider refactoring.
Open

    @Override
    public boolean equals(Object obj) {
        if (this == obj)
            return true;
        if (obj == null)
Severity: Major
Found in bboxdb-server/src/main/java/org/bboxdb/network/packets/request/InsertTupleRequest.java and 11 other locations - About 2 hrs to fix
bboxdb-commons/src/main/java/org/bboxdb/commons/Pair.java on lines 77..98
bboxdb-server/src/main/java/org/bboxdb/network/client/ContinuousQueryState.java on lines 78..98
bboxdb-server/src/main/java/org/bboxdb/network/entity/ContinuousQueryServerState.java on lines 107..127
bboxdb-server/src/main/java/org/bboxdb/network/packets/request/CreateDistributionGroupRequest.java on lines 187..207
bboxdb-server/src/main/java/org/bboxdb/network/packets/request/CreateTableRequest.java on lines 191..211
bboxdb-server/src/main/java/org/bboxdb/network/packets/request/KeepAliveRequest.java on lines 170..190
bboxdb-server/src/main/java/org/bboxdb/network/routing/RoutingHop.java on lines 52..72
bboxdb-server/src/main/java/org/bboxdb/query/filter/UserDefinedFilterDefinition.java on lines 56..76
bboxdb-server/src/main/java/org/bboxdb/storage/entity/CellGrid.java on lines 206..226
bboxdb-server/src/main/java/org/bboxdb/storage/entity/JoinedTupleIdentifier.java on lines 106..126
bboxdb-server/src/main/java/org/bboxdb/storage/entity/MultiTuple.java on lines 194..214

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 136.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 12 locations. Consider refactoring.
Open

    @Override
    public boolean equals(Object obj) {
        if (this == obj)
            return true;
        if (obj == null)
Severity: Major
Found in bboxdb-server/src/main/java/org/bboxdb/storage/entity/MultiTuple.java and 11 other locations - About 2 hrs to fix
bboxdb-commons/src/main/java/org/bboxdb/commons/Pair.java on lines 77..98
bboxdb-server/src/main/java/org/bboxdb/network/client/ContinuousQueryState.java on lines 78..98
bboxdb-server/src/main/java/org/bboxdb/network/entity/ContinuousQueryServerState.java on lines 107..127
bboxdb-server/src/main/java/org/bboxdb/network/packets/request/CreateDistributionGroupRequest.java on lines 187..207
bboxdb-server/src/main/java/org/bboxdb/network/packets/request/CreateTableRequest.java on lines 191..211
bboxdb-server/src/main/java/org/bboxdb/network/packets/request/InsertTupleRequest.java on lines 144..164
bboxdb-server/src/main/java/org/bboxdb/network/packets/request/KeepAliveRequest.java on lines 170..190
bboxdb-server/src/main/java/org/bboxdb/network/routing/RoutingHop.java on lines 52..72
bboxdb-server/src/main/java/org/bboxdb/query/filter/UserDefinedFilterDefinition.java on lines 56..76
bboxdb-server/src/main/java/org/bboxdb/storage/entity/CellGrid.java on lines 206..226
bboxdb-server/src/main/java/org/bboxdb/storage/entity/JoinedTupleIdentifier.java on lines 106..126

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 136.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public static DeleteTableRequest decodeTuple(final ByteBuffer encodedPackage) throws PacketEncodeException {
        final short sequenceNumber = NetworkPackageDecoder.getRequestIDFromRequestPackage(encodedPackage);
        
        final boolean decodeResult = NetworkPackageDecoder.validateRequestPackageHeader(encodedPackage, NetworkConst.REQUEST_TYPE_DELETE_TABLE);
Severity: Major
Found in bboxdb-server/src/main/java/org/bboxdb/network/packets/request/DeleteTableRequest.java and 1 other location - About 1 hr to fix
bboxdb-server/src/main/java/org/bboxdb/network/packets/request/DeleteDistributionGroupRequest.java on lines 71..91

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 126.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public static DeleteDistributionGroupRequest decodeTuple(final ByteBuffer encodedPackage) throws PacketEncodeException {
        final short sequenceNumber = NetworkPackageDecoder.getRequestIDFromRequestPackage(encodedPackage);
        
        final boolean decodeResult = NetworkPackageDecoder.validateRequestPackageHeader(encodedPackage, NetworkConst.REQUEST_TYPE_DELETE_DISTRIBUTION_GROUP);
Severity: Major
Found in bboxdb-server/src/main/java/org/bboxdb/network/packets/request/DeleteDistributionGroupRequest.java and 1 other location - About 1 hr to fix
bboxdb-server/src/main/java/org/bboxdb/network/packets/request/DeleteTableRequest.java on lines 73..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 126.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

            case QUERY_PREDEFINED_BUS_ROAD:
                udfNameField.setText(UserDefinedGeoJsonSpatialFilter.class.getCanonicalName());
                udfValueField.setText("");
                table1Field.setSelectedItem("osmgroup_buses");
                table2Field.setSelectedItem("osmgroup_roads");
Severity: Major
Found in bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java and 4 other locations - About 1 hr to fix
bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java on lines 425..439
bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java on lines 440..454
bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java on lines 470..484
bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java on lines 485..499

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

/*******************************************************************************
 *
 *    Copyright (C) 2015-2022 the BBoxDB project
 *  
 *    Licensed under the Apache License, Version 2.0 (the "License");
Severity: Major
Found in bboxdb-server/src/main/java/org/bboxdb/network/packets/response/MultipleTupleEndResponse.java and 2 other locations - About 1 hr to fix
bboxdb-server/src/main/java/org/bboxdb/network/packets/response/MultipleTupleStartResponse.java on lines 1..68
bboxdb-server/src/main/java/org/bboxdb/network/packets/response/PageEndResponse.java on lines 1..68

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

            case QUERY_PREDEFINED_BUS_FOREST_RELAXTED:
                udfNameField.setText(UserDefinedGeoJsonSpatialFilter.class.getCanonicalName());
                udfValueField.setText("");
                table1Field.setSelectedItem("osmgroup_buses");
                table2Field.setSelectedItem("osmgroup_forests");
Severity: Major
Found in bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java and 4 other locations - About 1 hr to fix
bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java on lines 410..424
bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java on lines 425..439
bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java on lines 440..454
bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java on lines 485..499

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

            case QUERY_PREDEFINED_BUS_FOREST_STRICT:
                udfNameField.setText(UserDefinedGeoJsonSpatialFilterStrict.class.getCanonicalName());
                udfValueField.setText("");
                table1Field.setSelectedItem("osmgroup_buses");
                table2Field.setSelectedItem("osmgroup_forests");
Severity: Major
Found in bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java and 4 other locations - About 1 hr to fix
bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java on lines 410..424
bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java on lines 425..439
bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java on lines 440..454
bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java on lines 470..484

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

/*******************************************************************************
 *
 *    Copyright (C) 2015-2022 the BBoxDB project
 *  
 *    Licensed under the Apache License, Version 2.0 (the "License");
Severity: Major
Found in bboxdb-server/src/main/java/org/bboxdb/network/packets/response/PageEndResponse.java and 2 other locations - About 1 hr to fix
bboxdb-server/src/main/java/org/bboxdb/network/packets/response/MultipleTupleEndResponse.java on lines 1..68
bboxdb-server/src/main/java/org/bboxdb/network/packets/response/MultipleTupleStartResponse.java on lines 1..68

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

            case QUERY_PREDEFINED_BUS_ELIZABETH:
                udfNameField.setText(UserDefinedGeoJsonSpatialFilter.class.getCanonicalName());
                udfValueField.setText("name:Elizabeth Street");
                table1Field.setSelectedItem("osmgroup_buses");
                table2Field.setSelectedItem("osmgroup_roads");
Severity: Major
Found in bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java and 4 other locations - About 1 hr to fix
bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java on lines 410..424
bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java on lines 440..454
bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java on lines 470..484
bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java on lines 485..499

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

/*******************************************************************************
 *
 *    Copyright (C) 2015-2022 the BBoxDB project
 *  
 *    Licensed under the Apache License, Version 2.0 (the "License");
Severity: Major
Found in bboxdb-server/src/main/java/org/bboxdb/network/packets/response/MultipleTupleStartResponse.java and 2 other locations - About 1 hr to fix
bboxdb-server/src/main/java/org/bboxdb/network/packets/response/MultipleTupleEndResponse.java on lines 1..68
bboxdb-server/src/main/java/org/bboxdb/network/packets/response/PageEndResponse.java on lines 1..68

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

            case QUERY_PREDEFINED_BUS_BRIDGE:
                udfNameField.setText(UserDefinedGeoJsonSpatialFilter.class.getCanonicalName());
                udfValueField.setText("bridge:yes");
                table1Field.setSelectedItem("osmgroup_buses");
                table2Field.setSelectedItem("osmgroup_roads");
Severity: Major
Found in bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java and 4 other locations - About 1 hr to fix
bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java on lines 410..424
bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java on lines 425..439
bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java on lines 470..484
bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java on lines 485..499

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 6 locations. Consider refactoring.
Open

    @Override
    public boolean equals(Object obj) {
        if (this == obj)
            return true;
        if (obj == null)
Severity: Major
Found in bboxdb-server/src/main/java/org/bboxdb/network/packets/request/HelloRequest.java and 5 other locations - About 1 hr to fix
bboxdb-server/src/main/java/org/bboxdb/network/packets/response/HelloResponse.java on lines 125..142
bboxdb-server/src/main/java/org/bboxdb/storage/entity/TupleEntityIdentifier.java on lines 52..69
bboxdb-server/src/main/java/org/bboxdb/storage/sstable/spatialindex/SpatialIndexEntry.java on lines 69..86
bboxdb-server/src/main/java/org/bboxdb/storage/sstable/spatialindex/rtree/RTreeDirectoryNode.java on lines 341..358
bboxdb-server/src/main/java/org/bboxdb/storage/tuplestore/manager/DistributionRegionEntity.java on lines 46..63

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 6 locations. Consider refactoring.
Open

    @Override
    public boolean equals(Object obj) {
        if (this == obj)
            return true;
        if (obj == null)
Severity: Major
Found in bboxdb-server/src/main/java/org/bboxdb/network/packets/response/HelloResponse.java and 5 other locations - About 1 hr to fix
bboxdb-server/src/main/java/org/bboxdb/network/packets/request/HelloRequest.java on lines 125..142
bboxdb-server/src/main/java/org/bboxdb/storage/entity/TupleEntityIdentifier.java on lines 52..69
bboxdb-server/src/main/java/org/bboxdb/storage/sstable/spatialindex/SpatialIndexEntry.java on lines 69..86
bboxdb-server/src/main/java/org/bboxdb/storage/sstable/spatialindex/rtree/RTreeDirectoryNode.java on lines 341..358
bboxdb-server/src/main/java/org/bboxdb/storage/tuplestore/manager/DistributionRegionEntity.java on lines 46..63

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            case QUERY_PREDEFINED_STATIC_ROADS:
                udfNameField.setText("");
                udfValueField.setText("");
                table1Field.setSelectedItem("osmgroup_roads");
                table1ColorField.setSelectedItem("Blue");
Severity: Major
Found in bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java and 1 other location - About 1 hr to fix
bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java on lines 369..382

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            case QUERY_PREDEFINED_STATIC_FOREST:
                udfNameField.setText("");
                udfValueField.setText("");
                table1Field.setSelectedItem("osmgroup_forests");
                table1ColorField.setSelectedItem("Green");
Severity: Major
Found in bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java and 1 other location - About 1 hr to fix
bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java on lines 325..338

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Override
    public long writeToOutputStream(final OutputStream outputStream) throws PacketEncodeException {

        try {
            final byte[] tableBytes = table.getFullnameBytes();
Severity: Major
Found in bboxdb-server/src/main/java/org/bboxdb/network/packets/request/DeleteTableRequest.java and 1 other location - About 1 hr to fix
bboxdb-server/src/main/java/org/bboxdb/network/packets/request/DeleteDistributionGroupRequest.java on lines 42..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Override
    public long writeToOutputStream(final OutputStream outputStream) throws PacketEncodeException {

        try {
            final byte[] groupBytes = distributionGroup.getBytes();
Severity: Major
Found in bboxdb-server/src/main/java/org/bboxdb/network/packets/request/DeleteDistributionGroupRequest.java and 1 other location - About 1 hr to fix
bboxdb-server/src/main/java/org/bboxdb/network/packets/request/DeleteTableRequest.java on lines 44..64

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language