jnidzwetzki/bboxdb

File `QueryWindow.java` has 619 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*******************************************************************************
 *
 *    Copyright (C) 2015-2022 the BBoxDB project
 *  
 *    Licensed under the Apache License, Version 2.0 (the "License");

Found in bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java - About 1 day to fix

Method `addActionListener` has 248 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void addActionListener(final JComboBox<String> queryTypeBox, final JComboBox<String> predefinedQueriesBox,
            final JComboBox<String> table1Field, final JComboBox<String> table1ColorField, 
            final JComboBox<String> table2Field, final JComboBox<String> table2ColorField, 
            final JButton executeButton, final JTextField udfNameField, final JTextField udfValueField,
            final JComboBox<String> receiveWatermarksField, final JComboBox<String> receiveInvalidationsField) {

Found in bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java - About 1 day to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

/*******************************************************************************
 *
 *    Copyright (C) 2015-2022 the BBoxDB project
 *  
 *    Licensed under the Apache License, Version 2.0 (the "License");

Found in bboxdb-tools/src/main/java/org/bboxdb/tools/converter/osm/store/OSMJDBCH2NodeStore.java and 1 other location - About 1 day to fix

Read up
Read up

bboxdb-tools/src/main/java/org/bboxdb/tools/converter/osm/store/OSMJDBCDerbyNodeStore.java on lines 1..190

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 598.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Similar blocks of code found in 2 locations. Consider refactoring.
Open

/*******************************************************************************
 *
 *    Copyright (C) 2015-2022 the BBoxDB project
 *  
 *    Licensed under the Apache License, Version 2.0 (the "License");

Found in bboxdb-tools/src/main/java/org/bboxdb/tools/converter/osm/store/OSMJDBCDerbyNodeStore.java and 1 other location - About 1 day to fix

Read up
Read up

bboxdb-tools/src/main/java/org/bboxdb/tools/converter/osm/store/OSMJDBCH2NodeStore.java on lines 1..190

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 598.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

File `BBoxDBConnection.java` has 462 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*******************************************************************************
 *
 *    Copyright (C) 2015-2022 the BBoxDB project
 *
 *    Licensed under the Apache License, Version 2.0 (the "License");

Found in bboxdb-server/src/main/java/org/bboxdb/network/client/connection/BBoxDBConnection.java - About 7 hrs to fix

Method `equals` has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public boolean equals(Object obj) {
        if (this == obj)
            return true;
        if (obj == null)

Found in bboxdb-server/src/main/java/org/bboxdb/query/ContinuousQueryPlan.java - About 4 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

`BBoxDBConnection` has 34 methods (exceeds 20 allowed). Consider refactoring.
Open

public class BBoxDBConnection {

    /**
     * The sequence number generator
     */

Found in bboxdb-server/src/main/java/org/bboxdb/network/client/connection/BBoxDBConnection.java - About 4 hrs to fix

`OperationFutureImpl` has 30 methods (exceeds 20 allowed). Consider refactoring.
Open

public class OperationFutureImpl<T> implements OperationFuture, FutureErrorCallback {

    /**
     * The tuple send delayer
     */

Found in bboxdb-server/src/main/java/org/bboxdb/network/client/future/client/OperationFutureImpl.java - About 3 hrs to fix

Method `runThread` has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    protected void runThread() throws Exception {
    
        logger.info("New worker thread for a continuous query has started");
        queryResult = connection.queryContinuous(qp);

Found in bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/ContinuousQueryRunable.java - About 3 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `mouseMoved` has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    public void mouseMoved(final MouseEvent e) {

        if(renderedElements == null) {
            return;

Found in bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/MouseOverlayHandler.java - About 2 hrs to fix

Method `prepartition` has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void prepartition(final CommandLine line) {
        final List<String> requiredArgs = Arrays.asList(CLIParameter.FILE,
                CLIParameter.FORMAT, CLIParameter.DISTRIBUTION_GROUP, CLIParameter.PARTITIONS);

        checkRequiredArgs(requiredArgs);

Found in bboxdb-tools/src/main/java/org/bboxdb/tools/cli/CLI.java - About 2 hrs to fix

File `OperationFutureImpl.java` has 282 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*******************************************************************************
 *
 *    Copyright (C) 2015-2022 the BBoxDB project
 *
 *    Licensed under the Apache License, Version 2.0 (the "License");

Found in bboxdb-server/src/main/java/org/bboxdb/network/client/future/client/OperationFutureImpl.java - About 2 hrs to fix

Method `updateRegistration` has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void updateRegistration() throws BBoxDBException {

        try {
            double maxEnlargementAbsolute = 0;
            double maxEnlargementFactor = 1;

Found in bboxdb-server/src/main/java/org/bboxdb/distribution/zookeeper/ContinuousQueryEnlargementRegisterer.java - About 2 hrs to fix

Method `prepartition` has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    private void prepartition(final CommandLine line) {
        final List<String> requiredArgs = Arrays.asList(CLIParameter.FILE,
                CLIParameter.FORMAT, CLIParameter.DISTRIBUTION_GROUP, CLIParameter.PARTITIONS);

        checkRequiredArgs(requiredArgs);

Found in bboxdb-tools/src/main/java/org/bboxdb/tools/cli/CLI.java - About 2 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

`NetworkOperationFutureMultiImpl` has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

public class NetworkOperationFutureMultiImpl implements NetworkOperationFuture {
    
    /**
     * The futures
     */

Found in bboxdb-server/src/main/java/org/bboxdb/network/client/future/network/NetworkOperationFutureMultiImpl.java - About 2 hrs to fix

Method `setupProducer` has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public void setupProducer(final int resultId) {

        logger.debug("Starting producer for {}", resultId);

        final Runnable producer = new Runnable() {

Found in bboxdb-server/src/main/java/org/bboxdb/network/client/future/client/helper/AbstractTheadedListFutureIterator.java - About 2 hrs to fix

Method `equals` has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public boolean equals(Object obj) {
        if (this == obj)
            return true;
        if (!super.equals(obj))

Found in bboxdb-server/src/main/java/org/bboxdb/query/ContinuousSpatialJoinQueryPlan.java - About 2 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `isCovering` has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    public boolean isCovering(final Hyperrectangle otherBox) {
        if(this == FULL_SPACE || otherBox == FULL_SPACE) {
            return true;
        }

Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java - About 2 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

`NetworkOperationFutureImpl` has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

public class NetworkOperationFutureImpl implements NetworkOperationFuture {

    /**
     * The id of the operation
     */

Found in bboxdb-server/src/main/java/org/bboxdb/network/client/future/network/NetworkOperationFutureImpl.java - About 2 hrs to fix

Method `buildTableModel` has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private AbstractTableModel buildTableModel() {
        
        final AbstractTableModel tableModel = new AbstractTableModel() {
            
            /**

Found in bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/ResultDetailsWindow.java - About 2 hrs to fix