Sign upLogin

jnidzwetzki/bitfinex-v2-wss-api-java

View on GitHub
Star
src/main/java/com/github/jnidzwetzki/bitfinex/v2/SimpleBitfinexApiBroker.java

Summary

Maintainability
A
2 hrs
Test Coverage

File SimpleBitfinexApiBroker.java has 562 lines of code (exceeds 250 allowed). Consider refactoring.
Invalid

/*******************************************************************************
 *
 *    Copyright (C) 2015-2018 Jan Kristof Nidzwetzki
 *
 *    Licensed under the Apache License, Version 2.0 (the "License");
Severity: Major
Found in src/main/java/com/github/jnidzwetzki/bitfinex/v2/SimpleBitfinexApiBroker.java - About 1 day to fix

    SimpleBitfinexApiBroker has 32 methods (exceeds 20 allowed). Consider refactoring.
    Invalid

    public class SimpleBitfinexApiBroker implements Closeable, BitfinexWebsocketClient {

    /**
     * The bitfinex api
     */
    Severity: Minor
    Found in src/main/java/com/github/jnidzwetzki/bitfinex/v2/SimpleBitfinexApiBroker.java - About 4 hrs to fix

      Method setupCommandCallbacks has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Invalid

          private void setupCommandCallbacks() {
        commandCallbacks = new HashMap<>();
        commandCallbacks.put("info", new DoNothingCommandCallback());

        // TODO: hb is not ping:pong
      Severity: Major
      Found in src/main/java/com/github/jnidzwetzki/bitfinex/v2/SimpleBitfinexApiBroker.java - About 2 hrs to fix

        Method reconnect has 54 lines of code (exceeds 25 allowed). Consider refactoring.
        Invalid

            @Override
    public synchronized boolean reconnect() {
        logger.debug("reconnect() called");
        Closeable authSuccessEventCallback = null;
        Closeable authFailedCallback = null;
        Severity: Major
        Found in src/main/java/com/github/jnidzwetzki/bitfinex/v2/SimpleBitfinexApiBroker.java - About 2 hrs to fix

          Method connect has 52 lines of code (exceeds 25 allowed). Consider refactoring.
          Invalid

              @Override
    public void connect() throws BitfinexClientException {
        logger.debug("connect() called");
        Closeable authSuccessEventCallback = null;
        Closeable authFailedCallback = null;
          Severity: Major
          Found in src/main/java/com/github/jnidzwetzki/bitfinex/v2/SimpleBitfinexApiBroker.java - About 2 hrs to fix

            Method handleChannelCallback has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Invalid

                private void handleChannelCallback(final String message) {
        // Channel callback
        updateConnectionHeartbeat();

        // JSON callback
            Severity: Minor
            Found in src/main/java/com/github/jnidzwetzki/bitfinex/v2/SimpleBitfinexApiBroker.java - About 1 hr to fix

              Method createChannelCallbackHandler has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Invalid

                  private ChannelCallbackHandler createChannelCallbackHandler(final int channelId, final BitfinexStreamSymbol symbol) {
        if (symbol instanceof BitfinexCandlestickSymbol) {
            final CandlestickHandler handler = new CandlestickHandler(channelId, (BitfinexCandlestickSymbol) symbol);
            handler.onCandlesticksEvent(callbackRegistry::acceptCandlesticksEvent);
            return handler;
              Severity: Minor
              Found in src/main/java/com/github/jnidzwetzki/bitfinex/v2/SimpleBitfinexApiBroker.java - About 1 hr to fix

                Method handleChannelCallback has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Invalid

                    private void handleChannelCallback(final String message) {
        // Channel callback
        updateConnectionHeartbeat();

        // JSON callback
                Severity: Minor
                Found in src/main/java/com/github/jnidzwetzki/bitfinex/v2/SimpleBitfinexApiBroker.java - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method resubscribeChannels has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Invalid

                    private void resubscribeChannels() throws InterruptedException, BitfinexClientException {
        final Map<Integer, ChannelCallbackHandler> oldChannelIdSymbolMap = new HashMap<>();

        synchronized (channelIdToHandlerMap) {
            oldChannelIdSymbolMap.putAll(channelIdToHandlerMap);
                Severity: Minor
                Found in src/main/java/com/github/jnidzwetzki/bitfinex/v2/SimpleBitfinexApiBroker.java - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method createChannelCallbackHandler has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Invalid

                    private ChannelCallbackHandler createChannelCallbackHandler(final int channelId, final BitfinexStreamSymbol symbol) {
        if (symbol instanceof BitfinexCandlestickSymbol) {
            final CandlestickHandler handler = new CandlestickHandler(channelId, (BitfinexCandlestickSymbol) symbol);
            handler.onCandlesticksEvent(callbackRegistry::acceptCandlesticksEvent);
            return handler;
                Severity: Minor
                Found in src/main/java/com/github/jnidzwetzki/bitfinex/v2/SimpleBitfinexApiBroker.java - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid too many return statements within this method.
                Invalid

                            return handler;
                Severity: Major
                Found in src/main/java/com/github/jnidzwetzki/bitfinex/v2/SimpleBitfinexApiBroker.java - About 30 mins to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          } finally {
            Optional.ofNullable(authSuccessEventCallback).ifPresent(SimpleBitfinexApiBroker::safeClose);
            Optional.ofNullable(authFailedCallback).ifPresent(SimpleBitfinexApiBroker::safeClose);
            Optional.ofNullable(positionInitCallback).ifPresent(SimpleBitfinexApiBroker::safeClose);
            Optional.ofNullable(walletsInitCallback).ifPresent(SimpleBitfinexApiBroker::safeClose);
                  Severity: Major
                  Found in src/main/java/com/github/jnidzwetzki/bitfinex/v2/SimpleBitfinexApiBroker.java and 1 other location - About 1 hr to fix
                  src/main/java/com/github/jnidzwetzki/bitfinex/v2/SimpleBitfinexApiBroker.java on lines 471..477

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 72.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          } finally {
            Optional.ofNullable(authSuccessEventCallback).ifPresent(SimpleBitfinexApiBroker::safeClose);
            Optional.ofNullable(authFailedCallback).ifPresent(SimpleBitfinexApiBroker::safeClose);
            Optional.ofNullable(positionInitCallback).ifPresent(SimpleBitfinexApiBroker::safeClose);
            Optional.ofNullable(walletsInitCallback).ifPresent(SimpleBitfinexApiBroker::safeClose);
                  Severity: Major
                  Found in src/main/java/com/github/jnidzwetzki/bitfinex/v2/SimpleBitfinexApiBroker.java and 1 other location - About 1 hr to fix
                  src/main/java/com/github/jnidzwetzki/bitfinex/v2/SimpleBitfinexApiBroker.java on lines 339..345

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 72.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Invalid

                              authFailedCallback = callbackRegistry.onAuthenticationFailedEvent(c -> {
                permissions = c.getPermissions();
                authenticated = false;
                while (connectionReadyLatch.getCount() != 0) {
                    connectionReadyLatch.countDown();
                  Severity: Minor
                  Found in src/main/java/com/github/jnidzwetzki/bitfinex/v2/SimpleBitfinexApiBroker.java and 1 other location - About 40 mins to fix
                  src/main/java/com/github/jnidzwetzki/bitfinex/v2/SimpleBitfinexApiBroker.java on lines 305..311

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 50.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Invalid

                              authFailedCallback = callbackRegistry.onAuthenticationFailedEvent(c -> {
                permissions = c.getPermissions();
                authenticated = false;
                while (connectionReadyLatch.getCount() != 0) {
                    connectionReadyLatch.countDown();
                  Severity: Minor
                  Found in src/main/java/com/github/jnidzwetzki/bitfinex/v2/SimpleBitfinexApiBroker.java and 1 other location - About 40 mins to fix
                  src/main/java/com/github/jnidzwetzki/bitfinex/v2/SimpleBitfinexApiBroker.java on lines 440..446

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 50.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status