Sign upLogin

joaomcteixeira/taurenmd

View on GitHub
Star
src/taurenmd/cli_distances.py

Summary

Maintainability
A
1 hr
Test Coverage

Cyclomatic complexity is too high in function main. (13)
Open

def main(
        topology,
        trajectories,
        insort=False,
        sel1='all',
Severity: Minor
Found in src/taurenmd/cli_distances.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function main has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

def main(
Severity: Major
Found in src/taurenmd/cli_distances.py - About 1 hr to fix

    Function "main" has 12 parameters, which is greater than the 7 authorized.
    Open

            topology,
        trajectories,
        insort=False,
        sel1='all',
        sel2='all',
    Severity: Major
    Found in src/taurenmd/cli_distances.py by sonar-python

    A long parameter list can indicate that a new structure should be created to wrap the numerous parameters or that the function is doing too many things.

    Noncompliant Code Example

    With a maximum number of 4 parameters:

    def do_something(param1, param2, param3, param4, param5):
    ...

    Compliant Solution

    def do_something(param1, param2, param3, param4):
    ...

    There are no issues that match your filters.

    Category
    Status