Sign upLogin

joekhoobyar/cardiac

View on GitHub
Star
lib/cardiac/model/querying.rb

Summary

Maintainability
A
50 mins
Test Coverage

Method find_with_ids has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        def find_with_ids(*ids, &evaluator)
          expects_array = ids.first.kind_of?(Array)
          return ids.first if expects_array && ids.first.empty?
          ids = ids.flatten.compact.uniq
          case ids.size
Severity: Minor
Found in lib/cardiac/model/querying.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method find_by_identity has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        def find_by_identity(id, &evaluator)
          record = unwrap_remote_data identify(id).find_instance
          instantiate(record, remote: true, &evaluator) if record
        rescue Cardiac::RequestFailedError => e
          raise e unless e.status == 404  # Ignores 404 Not Found
Severity: Minor
Found in lib/cardiac/model/querying.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status