joel/heroku-resque-workers-scaler

View on GitHub

Showing 2 of 2 total issues

Method workers= has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

      def workers=(quantity)
        return unless authorized?

        quantity = quantity.to_i

Severity: Minor
Found in lib/heroku-resque-workers-scaler/scaler.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method after_enqueue_scale_up has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def after_enqueue_scale_up(*args)
    case Config.mode
    when :thresholds
      Config.thresholds.reverse_each do |scale_info|
        # Run backwards so it gets set to the highest value first
Severity: Minor
Found in lib/heroku-resque-workers-scaler/scaler.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language