Sign upLogin

joestrhq/AcronisFSS

View on GitHub
Star

Showing 48 of 48 total issues

Node has 40 methods (exceeds 20 allowed). Consider refactoring.
Open

public abstract class Node {

  @JsonAdapter(value = NodeUuidTypeAdapter.class, nullSafe = false)
  @SerializedName("uuid")
  private UUID uuid;
Severity: Minor
Found in src/main/java/at/or/joestr/acronisfss/api/structures/Node.java - About 5 hrs to fix

    Device has 26 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public class Device {
  private UUID uuid;
  private String appVersion;
  private Filesystem filesystem;
  private LocalDateTime lastContactTime;
    Severity: Minor
    Found in src/main/java/at/or/joestr/acronisfss/api/structures/Device.java - About 3 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      /*
 * To change this license header, choose License Headers in Project Properties.
 * To change this template file, choose Tools | Templates
 * and open the template in the editor.
 */
      Severity: Major
      Found in src/main/java/at/or/joestr/acronisfss/api/structures/Error.java and 1 other location - About 2 hrs to fix
      src/main/java/at/or/joestr/acronisfss/api/classes/OAuth2Token.java on lines 1..59

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 152.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      /*
 * To change this license header, choose License Headers in Project Properties.
 * To change this template file, choose Tools | Templates
 * and open the template in the editor.
 */
      Severity: Major
      Found in src/main/java/at/or/joestr/acronisfss/api/classes/OAuth2Token.java and 1 other location - About 2 hrs to fix
      src/main/java/at/or/joestr/acronisfss/api/structures/Error.java on lines 1..57

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 152.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      AuditLogEntry has 22 methods (exceeds 20 allowed). Consider refactoring.
      Open

      public class AuditLogEntry {

  private UUID uuid;
  private int code;
  private LocalDateTime createdAt;
      Severity: Minor
      Found in src/main/java/at/or/joestr/acronisfss/api/structures/AuditLogEntry.java - About 2 hrs to fix

        Method getAuditLogEntries has 54 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          public static List<AuditLogEntry> getAuditLogEntries(URI apiUri, String bearerToken, AuditLogEntriesListFilter auditLogFilter) throws IOException, InterruptedException, URISyntaxException {
    ArrayList<AuditLogEntry> result = null;

    URIBuilder uri
      = new URIBuilder(apiUri.toString() + ENDPOINT_PATH)
        Severity: Major
        Found in src/main/java/at/or/joestr/acronisfss/api/endpoints/AuditLogEndpoint.java - About 2 hrs to fix

          Method getDevices has 50 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            public static List<Device> getDevices(URI apiUri, String bearerToken, DeviceListFilter deviceListFilter) throws URISyntaxException, IOException, InterruptedException {
    ArrayList<Device> result = null;

    URIBuilder uri
      = new URIBuilder(apiUri.toString() + ENDPOINT_PATH)
          Severity: Minor
          Found in src/main/java/at/or/joestr/acronisfss/api/endpoints/DeviceEndpoint.java - About 2 hrs to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                result = new Device(
      UUID.fromString(jsonDeviceObject.get("uuid").getAsString()),
      jsonDeviceObject.get("app_version").getAsString(),
      Filesystem.values()[jsonDeviceObject.get("filesystem").getAsInt() - 1],
      LocalDateTime.parse(jsonDeviceObject.get("last_contact_time").getAsString(), DateTimeFormatter.ISO_DATE_TIME),
            Severity: Major
            Found in src/main/java/at/or/joestr/acronisfss/api/endpoints/DeviceEndpoint.java and 1 other location - About 2 hrs to fix
            src/main/java/at/or/joestr/acronisfss/api/endpoints/DeviceEndpoint.java on lines 87..101

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 128.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                  Device resultEntry = new Device(
        UUID.fromString(jsonDeviceObject.get("uuid").getAsString()),
        jsonDeviceObject.get("app_version").getAsString(),
        Filesystem.values()[jsonDeviceObject.get("filesystem").getAsInt() - 1],
        LocalDateTime.parse(jsonDeviceObject.get("last_contact_time").getAsString(), DateTimeFormatter.ISO_DATE_TIME),
            Severity: Major
            Found in src/main/java/at/or/joestr/acronisfss/api/endpoints/DeviceEndpoint.java and 1 other location - About 2 hrs to fix
            src/main/java/at/or/joestr/acronisfss/api/endpoints/DeviceEndpoint.java on lines 149..163

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 128.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method getDeviceInformation has 45 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              public static Device getDeviceInformation(URI apiUri, String bearerToken, UUID deviceUuid, TenantFilter tenantFilter) throws URISyntaxException, IOException, InterruptedException {
    Device result = null;

    URIBuilder uri
      = new URIBuilder(apiUri.toString() + ENDPOINT_PATH + "/" + deviceUuid.toString())
            Severity: Minor
            Found in src/main/java/at/or/joestr/acronisfss/api/endpoints/DeviceEndpoint.java - About 1 hr to fix

              Method build has 38 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                public List<NameValuePair> build() {

    ArrayList<NameValuePair> result = new ArrayList<>();

    if (this.filterUser != null) {
              Severity: Minor
              Found in src/main/java/at/or/joestr/acronisfss/api/filter/AuditLogEntriesListFilter.java - About 1 hr to fix

                Method getToken has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  public static OAuth2Token getToken(URI authUri, String grantType, String username, String password) throws IOException, InterruptedException, URISyntaxException {

    OAuth2Token result;

    HttpRequest req = HttpRequest.newBuilder()
                Severity: Minor
                Found in src/main/java/at/or/joestr/acronisfss/api/endpoints/AuthorizationEndpoint.java - About 1 hr to fix

                  Method getAuditLogEntries has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                  Open

                    public static List<AuditLogEntry> getAuditLogEntries(URI apiUri, String bearerToken, AuditLogEntriesListFilter auditLogFilter) throws IOException, InterruptedException, URISyntaxException {
    ArrayList<AuditLogEntry> result = null;

    URIBuilder uri
      = new URIBuilder(apiUri.toString() + ENDPOINT_PATH)
                  Severity: Minor
                  Found in src/main/java/at/or/joestr/acronisfss/api/endpoints/AuditLogEndpoint.java - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method getToken has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    public static OAuth2Token getToken(URI authUri, String grantType, OAuth2Token token) throws IOException, InterruptedException, URISyntaxException {

    OAuth2Token result;

    HttpRequest req = HttpRequest.newBuilder()
                  Severity: Minor
                  Found in src/main/java/at/or/joestr/acronisfss/api/endpoints/AuthorizationEndpoint.java - About 1 hr to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    /*
 * To change this license header, choose License Headers in Project Properties.
 * To change this template file, choose Tools | Templates
 * and open the template in the editor.
 */
                    Severity: Major
                    Found in src/main/java/at/or/joestr/acronisfss/api/structures/NodeAuditLogEntry.java and 1 other location - About 1 hr to fix
                    src/main/java/at/or/joestr/acronisfss/api/structures/Share.java on lines 1..38

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 80.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    /*
 * To change this license header, choose License Headers in Project Properties.
 * To change this template file, choose Tools | Templates
 * and open the template in the editor.
 */
                    Severity: Major
                    Found in src/main/java/at/or/joestr/acronisfss/api/structures/Share.java and 1 other location - About 1 hr to fix
                    src/main/java/at/or/joestr/acronisfss/api/structures/NodeAuditLogEntry.java on lines 1..38

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 80.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Method createFolder has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      public static FolderNode createFolder(URI apiUri, String bearerToken, SyncAndShareNode node) throws URISyntaxException, IOException, InterruptedException {
    FolderNode result;

    URIBuilder uri
      = new URIBuilder(apiUri.toString() + ENDPOINT_PATH);
                    Severity: Minor
                    Found in src/main/java/at/or/joestr/acronisfss/api/endpoints/SyncAndShareNodesEndpoint.java - About 1 hr to fix

                      Method build has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                      Open

                        public List<NameValuePair> build() {

    ArrayList<NameValuePair> result = new ArrayList<>();

    if (this.filterUser != null) {
                      Severity: Minor
                      Found in src/main/java/at/or/joestr/acronisfss/api/filter/AuditLogEntriesListFilter.java - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method getDevices has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                      Open

                        public static List<Device> getDevices(URI apiUri, String bearerToken, DeviceListFilter deviceListFilter) throws URISyntaxException, IOException, InterruptedException {
    ArrayList<Device> result = null;

    URIBuilder uri
      = new URIBuilder(apiUri.toString() + ENDPOINT_PATH)
                      Severity: Minor
                      Found in src/main/java/at/or/joestr/acronisfss/api/endpoints/DeviceEndpoint.java - About 55 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                          result = new OAuth2Token(
      LocalDateTime.ofInstant(Instant.ofEpochSecond(
        jsonResponse.get("expires_on").getAsLong()),
        TimeZone.getTimeZone("UTC").toZoneId()
      ),
                      Severity: Minor
                      Found in src/main/java/at/or/joestr/acronisfss/api/endpoints/AuthorizationEndpoint.java and 1 other location - About 45 mins to fix
                      src/main/java/at/or/joestr/acronisfss/api/endpoints/AuthorizationEndpoint.java on lines 76..84

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 56.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language