Sign upLogin

johnholdun/dotwave

View on GitHub
Star

Showing 3 of 3 total issues

File app.js has 343 lines of code (exceeds 250 allowed). Consider refactoring.
Open

addEventListener('load', () => {
  const LIMIT = 24
  const el = document.querySelector('#app')
  const env = {
    template: () => {},
Severity: Minor
Found in public/app.js - About 4 hrs to fix

    Method save_results has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def save_results(method_name, page, limit)
    log(:info, "Fetch page #{page} of #{method_name}")

    result = send(method_name, page)
    existing_ids = database[:albums].where(id: result.map(&:id)).map(:id)
    Severity: Minor
    Found in lib/updater.rb - About 1 hr to fix

      Method save_results has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def save_results(method_name, page, limit)
    log(:info, "Fetch page #{page} of #{method_name}")

    result = send(method_name, page)
    existing_ids = database[:albums].where(id: result.map(&:id)).map(:id)
      Severity: Minor
      Found in lib/updater.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language