Sign upLogin

johnsonjh/gfcp

View on GitHub
Star

Showing 59 of 59 total issues

Avoid deeply nested control flow statements.
Open

                        if int(
                            sz,
                        ) <= len(
                            r,
                        ) && sz >= 2 {
Severity: Major
Found in gfcp_sess.go - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                    if dec.rx[i].flag() == KTypeData {
                    numDataShard++
                }
    Severity: Major
    Found in gfcp_fec.go - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                      if len(
                    dec.rx[i].data(),
                ) > maxlen {
                    maxlen = len(
                        dec.rx[i].data(),
      Severity: Major
      Found in gfcp_fec.go - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            if (GFcp.cwnd+1)*mss <= GFcp.incr {
                        GFcp.cwnd++
                    }
        Severity: Major
        Found in gfcp.go - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if nc, ok := l.conn.(net.Conn); ok {
        addr, _ := net.ResolveUDPAddr(
            "udp",
            nc.LocalAddr().String(),
        )
          Severity: Minor
          Found in gfcp_sess.go and 1 other location - About 45 mins to fix
          gfcp_sess.go on lines 630..647

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 114.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if nc, ok := s.conn.(net.Conn); ok {
            addr, _ := net.ResolveUDPAddr(
                "udp",
                nc.LocalAddr().String(),
            )
          Severity: Minor
          Found in gfcp_sess.go and 1 other location - About 45 mins to fix
          gfcp_sess.go on lines 1072..1089

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 114.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method GFCP.Input has 6 return statements (exceeds 4 allowed).
          Open

          func (
    GFcp *GFCP,
) Input(
    data []byte,
    regular,
          Severity: Major
          Found in gfcp.go - About 40 mins to fix

            Method UDPSession.Read has 6 return statements (exceeds 4 allowed).
            Open

            func (
    s *UDPSession,
) Read(
    b []byte,
) (
            Severity: Major
            Found in gfcp_sess.go - About 40 mins to fix

              Function newUDPSession has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  conv uint32,
    dataShards,
    parityShards int,
    l *Listener,
    conn net.PacketConn,
              Severity: Minor
              Found in gfcp_sess.go - About 35 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if !s.rd.IsZero() {
            if time.Now().After(
                s.rd,
            ) {
                s.mu.Unlock()
                Severity: Minor
                Found in gfcp_sess.go and 1 other location - About 30 mins to fix
                gfcp_sess.go on lines 393..407

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 100.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if !s.wd.IsZero() {
            if time.Now().After(
                s.wd,
            ) {
                s.mu.Unlock()
                Severity: Minor
                Found in gfcp_sess.go and 1 other location - About 30 mins to fix
                gfcp_sess.go on lines 287..301

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 100.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                2: cannot find package "go4.org/legal" in any of:
                Open

                    gfcpLegal "go4.org/legal"
                Severity: Minor
                Found in gfcp.go by govet

                TODO found
                Open

                        // TODO(jhj): Switch to pointer to avoid allocation.
                Severity: Minor
                Found in gfcp_fec.go by fixme

                XXX found
                Open

                .XXX
                Severity: Minor
                Found in .gitignore by fixme

                TODO found
                Open

                            // TODO(jhj): Switch to pointer to avoid allocation
                Severity: Minor
                Found in gfcp.go by fixme

                TODO found
                Open

                                    // TODO(jhj): Switch to pointer to avoid allocation.
                Severity: Minor
                Found in gfcp_sess.go by fixme

                TODO found
                Open

                        echo "TODO: Port of full coverage tools to PowerShell"
                Severity: Minor
                Found in .gitlab-ci.yml by fixme

                XXX found
                Open

                    }*/ // XXX(jhj): buffer can't be nil?
                Severity: Minor
                Found in gfcp.go by fixme

                XXX found
                Open

                            // XXX(jhj) ??? FUCK YOU CHINKS
                Severity: Minor
                Found in gfcp.go by fixme
                Severity
                Category
                Status
                Source
                Language