Sign upLogin

johnsonjh/gfpsgo

View on GitHub
Star
psgo.go

Summary

Maintainability
C
1 day
Test Coverage

File psgo.go has 685 lines of code (exceeds 500 allowed). Consider refactoring.
Open

// Copyright 2021 Jeffery H. Johnson <trnsz@pobox.com>
// Copyright 2021 Gridfinity, LLC.
// Copyright 2020 The psgo authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
Severity: Minor
Found in psgo.go - About 6 hrs to fix

    Function JoinNamespaceAndProcessInfoWithOptions has 68 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func JoinNamespaceAndProcessInfoWithOptions(
    pid string,
    descriptors []string,
    options *JoinNamespaceOpts,
) ([][]string, error) {
    Severity: Minor
    Found in psgo.go - About 1 hr to fix

      Function JoinNamespaceAndProcessInfoWithOptions has 10 return statements (exceeds 4 allowed).
      Open

      func JoinNamespaceAndProcessInfoWithOptions(
    pid string,
    descriptors []string,
    options *JoinNamespaceOpts,
) ([][]string, error) {
      Severity: Major
      Found in psgo.go - About 1 hr to fix

        Function findID has 5 return statements (exceeds 4 allowed).
        Open

        func findID(
    idStr string,
    mapping []IDMap,
    lookupFunc func(uid string) (string, error),
    overflowFile string,
        Severity: Major
        Found in psgo.go - About 35 mins to fix

          Function JoinNamespaceAndProcessInfoWithOptions has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
          Open

          func JoinNamespaceAndProcessInfoWithOptions(
    pid string,
    descriptors []string,
    options *JoinNamespaceOpts,
) ([][]string, error) {
          Severity: Minor
          Found in psgo.go - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func processHUSER(p *process.Process, ctx *psContext) (string, error) {
    if hp := findHostProcess(p, ctx); hp != nil {
        if ctx.opts != nil && len(ctx.opts.UIDMap) > 0 {
            return findID(
                hp.Status.Uids[1],
          Severity: Major
          Found in psgo.go and 1 other location - About 1 hr to fix
          psgo.go on lines 933..946

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 145.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func processHGROUP(p *process.Process, ctx *psContext) (string, error) {
    if hp := findHostProcess(p, ctx); hp != nil {
        if ctx.opts != nil && len(ctx.opts.GIDMap) > 0 {
            return findID(
                hp.Status.Gids[1],
          Severity: Major
          Found in psgo.go and 1 other location - About 1 hr to fix
          psgo.go on lines 915..928

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 145.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Your code does not pass gofmt in 1 place. Go fmt your code!
          Open

          // Copyright 2021 Jeffery H. Johnson <trnsz@pobox.com>
          Severity: Minor
          Found in psgo.go by gofmt

          There are no issues that match your filters.

          Category
          Status