johnsonjh/gohighway

View on GitHub

Showing 10 of 10 total issues

File sum.py has 293 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import peachpy.x86_64


class State:
    def __init__(self):
Severity: Minor
Found in sum.py - About 3 hrs to fix

    Function update has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def update(plo, phi, state):
        PADDQ(state.v1lo, plo)
        PADDQ(state.v1hi, phi)
        PADDQ(state.v1lo, state.mul0lo)
        PADDQ(state.v1hi, state.mul0hi)
    Severity: Minor
    Found in sum.py - About 1 hr to fix

      Function memcpy16 has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      def memcpy16(xmm0, p, l):
      
          b = GeneralPurposeRegister64()
          offs = GeneralPurposeRegister64()
          XOR(offs, offs)
      Severity: Minor
      Found in sum.py - About 1 hr to fix

        Function zipper has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def zipper(mask, mlo, mhi, vlo, vhi):
        Severity: Minor
        Found in sum.py - About 35 mins to fix

          exported type Lanes should have comment or be unexported
          Open

          type Lanes [NumLanes]uint64
          Severity: Minor
          Found in highway.go by golint

          exported function Hash should have comment or be unexported
          Open

          func Hash(key Lanes, bytes []byte) uint64 {
          Severity: Minor
          Found in highway.go by golint

          exported const NumLanes should have comment (or a comment on this block) or be unexported
          Open

              NumLanes   = 4
          Severity: Minor
          Found in highway.go by golint

          2: cannot find package "github.com/intel-go/cpuid" in any of:
          Open

              "github.com/intel-go/cpuid"
          Severity: Minor
          Found in highway.go by govet

          TODO found
          Open

                  # TODO(dgryski): remove this variable; reuse reg_p_len
          Severity: Minor
          Found in sum.py by fixme

          TODO found
          Open

                  # TODO(dgryski): copy(finalPacket[28:], bytes[len(bytes)-4:])
          Severity: Minor
          Found in sum.py by fixme
          Severity
          Category
          Status
          Source
          Language