Sign upLogin

johnsonjh/jleveldb

View on GitHub
Star
leveldb/cache/cache.go

Summary

Maintainability
D
1 day
Test Coverage

File cache.go has 518 lines of code (exceeds 500 allowed). Consider refactoring.
Open

// Copyright © 2012, Suryandaru Triandana <syndtr@gmail.com>
// Copyright © 2021, Jeffrey H. Johnson <trnsz@pobox.com>
//
// All rights reserved.
//
Severity: Minor
Found in leveldb/cache/cache.go - About 2 hrs to fix

    Method mBucket.delete has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
    Open

    func (b *mBucket) delete(r *Cache, h *mNode, hash uint32, ns, key uint64) (done, deleted bool) {
    b.mu.Lock()

    if b.frozen {
        b.mu.Unlock()
    Severity: Minor
    Found in leveldb/cache/cache.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method mNode.initBucket has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
    Open

    func (n *mNode) initBucket(i uint32) *mBucket {
    if b := (*mBucket)(atomic.LoadPointer(&n.buckets[i])); b != nil {
        return b
    }
    Severity: Minor
    Found in leveldb/cache/cache.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method mBucket.delete has 53 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (b *mBucket) delete(r *Cache, h *mNode, hash uint32, ns, key uint64) (done, deleted bool) {
    b.mu.Lock()

    if b.frozen {
        b.mu.Unlock()
    Severity: Minor
    Found in leveldb/cache/cache.go - About 1 hr to fix

      Method Cache.Get has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
      Open

      func (r *Cache) Get(ns, key uint64, setFunc func() (size int, value Value)) *Handle {
    r.mu.RLock()
    defer r.mu.RUnlock()
    if r.closed {
        return nil
      Severity: Minor
      Found in leveldb/cache/cache.go - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                          if n.value == nil {
                        n.size = 0
                        n.mu.Unlock()
                        n.unref()
                        return nil
      Severity: Major
      Found in leveldb/cache/cache.go - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            if setFunc == nil {
                        n.mu.Unlock()
                        n.unref()
                        return nil
                    }
        Severity: Major
        Found in leveldb/cache/cache.go - About 45 mins to fix

          Method mBucket.get has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          func (b *mBucket) get(r *Cache, h *mNode, hash uint32, ns, key uint64, noset bool) (done, added bool, n *Node) {
          Severity: Minor
          Found in leveldb/cache/cache.go - About 35 mins to fix

            Method Cache.Close has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
            Open

            func (r *Cache) Close() error {
    r.mu.Lock()
    if !r.closed {
        r.closed = true
            Severity: Minor
            Found in leveldb/cache/cache.go - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method Cache.Get has 5 return statements (exceeds 4 allowed).
            Open

            func (r *Cache) Get(ns, key uint64, setFunc func() (size int, value Value)) *Handle {
    r.mu.RLock()
    defer r.mu.RUnlock()
    if r.closed {
        return nil
            Severity: Major
            Found in leveldb/cache/cache.go - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if grow && atomic.CompareAndSwapInt32(&h.resizeInProgess, 0, 1) {
        nhLen := len(h.buckets) << 1
        nh := &mNode{
            buckets:         make([]unsafe.Pointer, nhLen),
            mask:            uint32(nhLen) - 1,
              Severity: Major
              Found in leveldb/cache/cache.go and 1 other location - About 1 hr to fix
              leveldb/cache/cache.go on lines 201..215

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 159.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if shrink && len(h.buckets) > mInitialSize && atomic.CompareAndSwapInt32(&h.resizeInProgess, 0, 1) {
            nhLen := len(h.buckets) >> 1
            nh := &mNode{
                buckets:         make([]unsafe.Pointer, nhLen),
                mask:            uint32(nhLen) - 1,
              Severity: Major
              Found in leveldb/cache/cache.go and 1 other location - About 1 hr to fix
              leveldb/cache/cache.go on lines 132..146

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 159.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status