Sign upLogin

johnsonjh/jleveldb

View on GitHub
Star
leveldb/journal/journal.go

Summary

Maintainability
C
7 hrs
Test Coverage

Method Reader.nextChunk has a Cognitive Complexity of 35 (exceeds 20 allowed). Consider refactoring.
Open

func (r *Reader) nextChunk(first bool) error {
    for {
        if r.j+headerSize <= r.n {
            checksum := binary.LittleEndian.Uint32(r.buf[r.j+0 : r.j+4])
            length := binary.LittleEndian.Uint16(r.buf[r.j+4 : r.j+6])
Severity: Minor
Found in leveldb/journal/journal.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Reader.nextChunk has 55 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (r *Reader) nextChunk(first bool) error {
    for {
        if r.j+headerSize <= r.n {
            checksum := binary.LittleEndian.Uint32(r.buf[r.j+0 : r.j+4])
            length := binary.LittleEndian.Uint16(r.buf[r.j+4 : r.j+6])
Severity: Minor
Found in leveldb/journal/journal.go - About 1 hr to fix

    Method Reader.nextChunk has 11 return statements (exceeds 4 allowed).
    Open

    func (r *Reader) nextChunk(first bool) error {
    for {
        if r.j+headerSize <= r.n {
            checksum := binary.LittleEndian.Uint32(r.buf[r.j+0 : r.j+4])
            length := binary.LittleEndian.Uint16(r.buf[r.j+4 : r.j+6])
    Severity: Major
    Found in leveldb/journal/journal.go - About 1 hr to fix

      Method singleReader.ReadByte has 6 return statements (exceeds 4 allowed).
      Open

      func (x *singleReader) ReadByte() (byte, error) {
    r := x.r
    if r.seq != x.seq {
        return 0, errors.New("leveldb/journal: stale reader")
    }
      Severity: Major
      Found in leveldb/journal/journal.go - About 40 mins to fix

        Method singleReader.Read has 6 return statements (exceeds 4 allowed).
        Open

        func (x *singleReader) Read(p []byte) (int, error) {
    r := x.r
    if r.seq != x.seq {
        return 0, errors.New("leveldb/journal: stale reader")
    }
        Severity: Major
        Found in leveldb/journal/journal.go - About 40 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              for r.i == r.j {
        if r.last {
            return 0, io.EOF
        }
        x.err = r.nextChunk(false)
          Severity: Minor
          Found in leveldb/journal/journal.go and 1 other location - About 30 mins to fix
          leveldb/journal/journal.go on lines 304..315

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 102.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              for r.i == r.j {
        if r.last {
            return 0, io.EOF
        }
        x.err = r.nextChunk(false)
          Severity: Minor
          Found in leveldb/journal/journal.go and 1 other location - About 30 mins to fix
          leveldb/journal/journal.go on lines 332..343

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 102.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status