Sign upLogin

johnsonjh/jleveldb

View on GitHub
Star
leveldb/table/reader.go

Summary

Maintainability
F
5 days
Test Coverage

File reader.go has 943 lines of code (exceeds 500 allowed). Consider refactoring.
Open

// Copyright © 2012, Suryandaru Triandana <syndtr@gmail.com>
// Copyright © 2021, Jeffrey H. Johnson <trnsz@pobox.com>
//
// All rights reserved.
//
Severity: Major
Found in leveldb/table/reader.go - About 1 day to fix

    Function NewReader has a Cognitive Complexity of 44 (exceeds 20 allowed). Consider refactoring.
    Open

    func NewReader(f io.ReaderAt, size int64, fd storage.FileDesc, cache *cache.NamespaceGetter, bpool *util.BufferPool, o *opt.Options) (*Reader, error) {
    if f == nil {
        return nil, errors.New("leveldb/table: nil file")
    }
    Severity: Minor
    Found in leveldb/table/reader.go - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function NewReader has 94 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func NewReader(f io.ReaderAt, size int64, fd storage.FileDesc, cache *cache.NamespaceGetter, bpool *util.BufferPool, o *opt.Options) (*Reader, error) {
    if f == nil {
        return nil, errors.New("leveldb/table: nil file")
    }
    Severity: Major
    Found in leveldb/table/reader.go - About 2 hrs to fix

      Method Reader.find has a Cognitive Complexity of 33 (exceeds 20 allowed). Consider refactoring.
      Open

      func (r *Reader) find(key []byte, filtered bool, ro *opt.ReadOptions, noValue bool) (rkey, value []byte, err error) {
    r.mu.RLock()
    defer r.mu.RUnlock()

    if r.err != nil {
      Severity: Minor
      Found in leveldb/table/reader.go - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method blockIter.Prev has 84 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (i *blockIter) Prev() bool {
    if i.dir == dirSOI || i.err != nil {
        return false
    } else if i.dir == dirReleased {
        i.err = ErrIterReleased
      Severity: Major
      Found in leveldb/table/reader.go - About 2 hrs to fix

        Reader has 21 methods (exceeds 20 allowed). Consider refactoring.
        Open

        type Reader struct {
    mu     sync.RWMutex
    fd     storage.FileDesc
    reader io.ReaderAt
    cache  *cache.NamespaceGetter
        Severity: Minor
        Found in leveldb/table/reader.go - About 2 hrs to fix

          Method Reader.find has 72 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func (r *Reader) find(key []byte, filtered bool, ro *opt.ReadOptions, noValue bool) (rkey, value []byte, err error) {
    r.mu.RLock()
    defer r.mu.RUnlock()

    if r.err != nil {
          Severity: Minor
          Found in leveldb/table/reader.go - About 1 hr to fix

            Method blockIter.Prev has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
            Open

            func (i *blockIter) Prev() bool {
    if i.dir == dirSOI || i.err != nil {
        return false
    } else if i.dir == dirReleased {
        i.err = ErrIterReleased
            Severity: Minor
            Found in leveldb/table/reader.go - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function NewReader has 12 return statements (exceeds 4 allowed).
            Open

            func NewReader(f io.ReaderAt, size int64, fd storage.FileDesc, cache *cache.NamespaceGetter, bpool *util.BufferPool, o *opt.Options) (*Reader, error) {
    if f == nil {
        return nil, errors.New("leveldb/table: nil file")
    }
            Severity: Major
            Found in leveldb/table/reader.go - About 1 hr to fix

              Method Reader.find has 11 return statements (exceeds 4 allowed).
              Open

              func (r *Reader) find(key []byte, filtered bool, ro *opt.ReadOptions, noValue bool) (rkey, value []byte, err error) {
    r.mu.RLock()
    defer r.mu.RUnlock()

    if r.err != nil {
              Severity: Major
              Found in leveldb/table/reader.go - About 1 hr to fix

                Method blockIter.Prev has 10 return statements (exceeds 4 allowed).
                Open

                func (i *blockIter) Prev() bool {
    if i.dir == dirSOI || i.err != nil {
        return false
    } else if i.dir == dirReleased {
        i.err = ErrIterReleased
                Severity: Major
                Found in leveldb/table/reader.go - About 1 hr to fix

                  Method blockIter.Next has 8 return statements (exceeds 4 allowed).
                  Open

                  func (i *blockIter) Next() bool {
    if i.dir == dirEOI || i.err != nil {
        return false
    } else if i.dir == dirReleased {
        i.err = ErrIterReleased
                  Severity: Major
                  Found in leveldb/table/reader.go - About 50 mins to fix

                    Function NewReader has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    func NewReader(f io.ReaderAt, size int64, fd storage.FileDesc, cache *cache.NamespaceGetter, bpool *util.BufferPool, o *opt.Options) (*Reader, error) {
                    Severity: Minor
                    Found in leveldb/table/reader.go - About 45 mins to fix

                      Method Reader.readRawBlock has 6 return statements (exceeds 4 allowed).
                      Open

                      func (r *Reader) readRawBlock(bh blockHandle, verifyChecksum bool) ([]byte, error) {
    data := r.bpool.Get(int(bh.length + blockTrailerLen))
    if _, err := r.reader.ReadAt(data, int64(bh.offset)); err != nil && err != io.EOF {
        return nil, err
    }
                      Severity: Major
                      Found in leveldb/table/reader.go - About 40 mins to fix

                        Method Reader.readBlockCached has 6 return statements (exceeds 4 allowed).
                        Open

                        func (r *Reader) readBlockCached(bh blockHandle, verifyChecksum, fillCache bool) (*block, util.Releaser, error) {
    if r.cache != nil {
        var (
            err error
            ch  *cache.Handle
                        Severity: Major
                        Found in leveldb/table/reader.go - About 40 mins to fix

                          Method Reader.readFilterBlockCached has 6 return statements (exceeds 4 allowed).
                          Open

                          func (r *Reader) readFilterBlockCached(bh blockHandle, fillCache bool) (*filterBlock, util.Releaser, error) {
    if r.cache != nil {
        var (
            err error
            ch  *cache.Handle
                          Severity: Major
                          Found in leveldb/table/reader.go - About 40 mins to fix

                            Method Reader.OffsetOf has 5 return statements (exceeds 4 allowed).
                            Open

                            func (r *Reader) OffsetOf(key []byte) (offset int64, err error) {
    r.mu.RLock()
    defer r.mu.RUnlock()

    if r.err != nil {
                            Severity: Major
                            Found in leveldb/table/reader.go - About 35 mins to fix

                              Method blockIter.Seek has 5 return statements (exceeds 4 allowed).
                              Open

                              func (i *blockIter) Seek(key []byte) bool {
    if i.err != nil {
        return false
    } else if i.dir == dirReleased {
        i.err = ErrIterReleased
                              Severity: Major
                              Found in leveldb/table/reader.go - About 35 mins to fix

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                func (i *blockIter) Last() bool {
    if i.err != nil {
        return false
    } else if i.dir == dirReleased {
        i.err = ErrIterReleased
                                Severity: Major
                                Found in leveldb/table/reader.go and 1 other location - About 1 hr to fix
                                leveldb/table/reader.go on lines 194..208

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 136.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                func (i *blockIter) First() bool {
    if i.err != nil {
        return false
    } else if i.dir == dirReleased {
        i.err = ErrIterReleased
                                Severity: Major
                                Found in leveldb/table/reader.go and 1 other location - About 1 hr to fix
                                leveldb/table/reader.go on lines 210..224

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 136.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                There are no issues that match your filters.

                                Category
                                Status