app/Contracts/Hooks/RecordNameTextExtenderInterface.php
The method recordNameAppend has a boolean flag argument $use_long, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function recordNameAppend(GedcomRecord $record, bool $use_long = false, string $size = ''): string;- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
The method recordNamePrepend has a boolean flag argument $use_long, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function recordNamePrepend(GedcomRecord $record, bool $use_long = false, string $size = ''): string;- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}