Sign upLogin

jon48/webtrees-lib

View on GitHub
Star
app/Module/GeoDispersion/Http/RequestHandlers/MapAdapterDeleteInvalidAction.php

Summary

Maintainability
A
1 hr
Test Coverage

Method handle has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handle(ServerRequestInterface $request): ResponseInterface
    {
        $tree = Validator::attributes($request)->tree();

        if ($this->module === null) {
Severity: Minor
Found in app/Module/GeoDispersion/Http/RequestHandlers/MapAdapterDeleteInvalidAction.php - About 1 hr to fix

    The class MapAdapterDeleteInvalidAction has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13.
    Open

    class MapAdapterDeleteInvalidAction implements RequestHandlerInterface
{
    private ?GeoDispersionModule $module;
    private GeoAnalysisViewDataService $geoview_data_service;
    private MapAdapterDataService $mapadapter_data_service;
    Severity: Minor
    Found in app/Module/GeoDispersion/Http/RequestHandlers/MapAdapterDeleteInvalidAction.php by phpmd

    CouplingBetweenObjects

    Since: 1.1.0

    A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

    Example

    class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

    Source https://phpmd.org/rules/design.html#couplingbetweenobjects

    Avoid using static access to class '\Fisharebest\Webtrees\FlashMessages' in method 'handle'.
    Open

                FlashMessages::addMessage(
                I18N::translate('The attached module could not be found.'),
                'danger'
            );
    Severity: Minor
    Found in app/Module/GeoDispersion/Http/RequestHandlers/MapAdapterDeleteInvalidAction.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Fisharebest\Webtrees\FlashMessages' in method 'handle'.
    Open

                FlashMessages::addMessage(
                I18N::translate('The view with ID “%s” does not exist.', I18N::number($view_id)),
                'danger'
            );
    Severity: Minor
    Found in app/Module/GeoDispersion/Http/RequestHandlers/MapAdapterDeleteInvalidAction.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
    Open

                    I18N::translate('The view with ID “%s” does not exist.', I18N::number($view_id)),
    Severity: Minor
    Found in app/Module/GeoDispersion/Http/RequestHandlers/MapAdapterDeleteInvalidAction.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
    Open

                    I18N::translate('The attached module could not be found.'),
    Severity: Minor
    Found in app/Module/GeoDispersion/Http/RequestHandlers/MapAdapterDeleteInvalidAction.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Fisharebest\Webtrees\FlashMessages' in method 'handle'.
    Open

                FlashMessages::addMessage(
                I18N::translate('An error occured while deleting the invalid map configurations.'),
                'danger'
            );
    Severity: Minor
    Found in app/Module/GeoDispersion/Http/RequestHandlers/MapAdapterDeleteInvalidAction.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Fisharebest\Webtrees\FlashMessages' in method 'handle'.
    Open

                FlashMessages::addMessage(
                I18N::translate('The invalid map configurations have been successfully deleted.'),
                'success'
            );
    Severity: Minor
    Found in app/Module/GeoDispersion/Http/RequestHandlers/MapAdapterDeleteInvalidAction.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
    Open

                    I18N::translate('The invalid map configurations have been successfully deleted.'),
    Severity: Minor
    Found in app/Module/GeoDispersion/Http/RequestHandlers/MapAdapterDeleteInvalidAction.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Fisharebest\Webtrees\Log' in method 'handle'.
    Open

                Log::addConfigurationLog('Module ' . $this->module->title() . ' : Error when deleting invalid map configurations: ' . $ex->getMessage());
    Severity: Minor
    Found in app/Module/GeoDispersion/Http/RequestHandlers/MapAdapterDeleteInvalidAction.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
    Open

                    I18N::translate('The view with ID “%s” does not exist.', I18N::number($view_id)),
    Severity: Minor
    Found in app/Module/GeoDispersion/Http/RequestHandlers/MapAdapterDeleteInvalidAction.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
    Open

                    I18N::translate('An error occured while deleting the invalid map configurations.'),
    Severity: Minor
    Found in app/Module/GeoDispersion/Http/RequestHandlers/MapAdapterDeleteInvalidAction.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid excessively long variable names like $mapadapter_data_service. Keep variable name length under 20.
    Open

            MapAdapterDataService $mapadapter_data_service
    Severity: Minor
    Found in app/Module/GeoDispersion/Http/RequestHandlers/MapAdapterDeleteInvalidAction.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $mapadapter_data_service. Keep variable name length under 20.
    Open

        private MapAdapterDataService $mapadapter_data_service;
    Severity: Minor
    Found in app/Module/GeoDispersion/Http/RequestHandlers/MapAdapterDeleteInvalidAction.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    There are no issues that match your filters.

    Category
    Status