Sign upLogin

jon48/webtrees-lib

View on GitHub
Star
app/Module/PatronymicLineage/PatronymicLineageModule.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method individuals has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

        Tree $tree,
        string $surn,
        string $salpha,
        string $galpha,
        bool $marnm,
Severity: Major
Found in app/Module/PatronymicLineage/PatronymicLineageModule.php - About 50 mins to fix

    Method surnames has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            Tree $tree,
        string $surn,
        string $salpha,
        bool $marnm,
        bool $fams,
    Severity: Minor
    Found in app/Module/PatronymicLineage/PatronymicLineageModule.php - About 45 mins to fix

      Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'title'.
      Open

              return /* I18N: Name of the “Patronymic lineage” module */ I18N::translate('Patronymic Lineages');
      Severity: Minor
      Found in app/Module/PatronymicLineage/PatronymicLineageModule.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid assigning values to variables in if clauses and the like (line '105', column '30').
      Open

          public function listUrl(Tree $tree, array $parameters = []): string
    {
        $surname = $parameters['surname'] ?? '';

        $xref = app(ServerRequestInterface::class)->getAttribute('xref', '');
      Severity: Minor
      Found in app/Module/PatronymicLineage/PatronymicLineageModule.php by phpmd

      IfStatementAssignment

      Since: 2.7.0

      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

      Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'description'.
      Open

              return /* I18N: Description of the “Patronymic lineage” module */ I18N::translate('Display lineages of people holding the same surname.');
      Severity: Minor
      Found in app/Module/PatronymicLineage/PatronymicLineageModule.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function loadRoutes(Map $router): void
    {
        $router->attach('', '', static function (Map $router): void {

            $router->attach('', '/module-maj/lineages', static function (Map $router): void {
      Severity: Major
      Found in app/Module/PatronymicLineage/PatronymicLineageModule.php and 1 other location - About 2 hrs to fix
      app/Module/MiscExtensions/MiscExtensionsModule.php on lines 83..96

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 131.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status