Sign upLogin

jon48/webtrees-lib

View on GitHub
Star
app/Module/Sosa/Http/RequestHandlers/SosaStatistics.php

Summary

Maintainability
A
1 hr
Test Coverage

Method statisticsByGenerations has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function statisticsByGenerations(SosaStatisticsService $sosa_stats_service): array
    {
        $stats_by_gen = $sosa_stats_service->statisticsByGenerations();

        $generation_stats = array();
Severity: Minor
Found in app/Module/Sosa/Http/RequestHandlers/SosaStatistics.php - About 1 hr to fix

    The class SosaStatistics has a coupling between objects value of 14. Consider to reduce the number of dependencies under 13.
    Open

    class SosaStatistics implements RequestHandlerInterface
{
    use ViewResponseTrait;

    private ?SosaModule $module;
    Severity: Minor
    Found in app/Module/Sosa/Http/RequestHandlers/SosaStatistics.php by phpmd

    CouplingBetweenObjects

    Since: 1.1.0

    A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

    Example

    class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

    Source https://phpmd.org/rules/design.html#couplingbetweenobjects

    Avoid using static access to class '\Fisharebest\Webtrees\Auth' in method 'handle'.
    Open

            $user = Auth::check() ? Validator::attributes($request)->user() : new DefaultUser();
    Severity: Minor
    Found in app/Module/Sosa/Http/RequestHandlers/SosaStatistics.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
    Open

                'title'             =>  I18N::translate('Sosa Statistics'),
    Severity: Minor
    Found in app/Module/Sosa/Http/RequestHandlers/SosaStatistics.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Brick\Math\BigInteger' in method 'statisticsByGenerations'.
    Open

                            BigInteger::of(2 * (int) $stats_by_gen[$gen - 1]['sosaCount'])
    Severity: Minor
    Found in app/Module/Sosa/Http/RequestHandlers/SosaStatistics.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Brick\Math\BigInteger' in method 'statisticsByGenerations'.
    Open

                        BigInteger::of((int) $stats_gen['sosaTotalCount']),
    Severity: Minor
    Found in app/Module/Sosa/Http/RequestHandlers/SosaStatistics.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
    Open

                throw new HttpNotFoundException(I18N::translate('The attached module could not be found.'));
    Severity: Minor
    Found in app/Module/Sosa/Http/RequestHandlers/SosaStatistics.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Brick\Math\BigInteger' in method 'statisticsGeneral'.
    Open

                    BigInteger::of($individual_count)
    Severity: Minor
    Found in app/Module/Sosa/Http/RequestHandlers/SosaStatistics.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Brick\Math\BigInteger' in method 'statisticsGeneral'.
    Open

                    BigInteger::of($ancestors_distinct_count),
    Severity: Minor
    Found in app/Module/Sosa/Http/RequestHandlers/SosaStatistics.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Brick\Math\BigInteger' in method 'statisticsByGenerations'.
    Open

                            BigInteger::of((int) $stats_gen['sosaCount']),
    Severity: Minor
    Found in app/Module/Sosa/Http/RequestHandlers/SosaStatistics.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Brick\Math\BigInteger' in method 'statisticsByGenerations'.
    Open

                        BigInteger::of((int) $stats_gen['sosaCount']),
    Severity: Minor
    Found in app/Module/Sosa/Http/RequestHandlers/SosaStatistics.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Brick\Math\BigInteger' in method 'statisticsByGenerations'.
    Open

                        BigInteger::of($gen_diff),
    Severity: Minor
    Found in app/Module/Sosa/Http/RequestHandlers/SosaStatistics.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Brick\Math\BigInteger' in method 'statisticsByGenerations'.
    Open

                        BigInteger::of((int) $stats_gen['sosaCount'])
    Severity: Minor
    Found in app/Module/Sosa/Http/RequestHandlers/SosaStatistics.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid excessively long variable names like $ancestors_distinct_count. Keep variable name length under 20.
    Open

            $ancestors_distinct_count = $sosa_stats_service->totalDistinctAncestors();
    Severity: Minor
    Found in app/Module/Sosa/Http/RequestHandlers/SosaStatistics.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid variables with short names like $q. Configured minimum length is 3.
    Open

        private function safeDivision(BigInteger $p, BigInteger $q, int $scale = 10, float $default = 0): float
    Severity: Minor
    Found in app/Module/Sosa/Http/RequestHandlers/SosaStatistics.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $p. Configured minimum length is 3.
    Open

        private function safeDivision(BigInteger $p, BigInteger $q, int $scale = 10, float $default = 0): float
    Severity: Minor
    Found in app/Module/Sosa/Http/RequestHandlers/SosaStatistics.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    There are no issues that match your filters.

    Category
    Status