jon48/webtrees-lib

File SosaStatisticsService.php has 358 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php

/**
 * webtrees-lib: MyArtJaub library for webtrees
 *

Method pedigreeCollapseByGenerationData has 110 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function pedigreeCollapseByGenerationData(): array
    {
        if (!$this->isPdoSupported()) {
            return [];
        }

The class SosaStatisticsService has 13 public methods. Consider refactoring SosaStatisticsService to keep number of public methods under 10.

Open

class SosaStatisticsService
{
    private UserInterface $user;
    private Tree $tree;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Method generationDepthStatsAtGeneration has 42 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function generationDepthStatsAtGeneration(int $gen): Collection
    {
        if (!$this->isPdoSupported()) {
            return collect();
        }

Method topMultipleAncestorsWithNoTies has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function topMultipleAncestorsWithNoTies(int $limit): Collection
    {
        $table_prefix = DB::connection()->getTablePrefix();
        $multiple_ancestors = DB::table('maj_sosa AS sosa')
            ->select('sosa.majs_i_id AS sosa_i_id')

Method ancestorsDispersionForGeneration has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function ancestorsDispersionForGeneration(int $gen): Collection
    {
        if (!$this->isPdoSupported()) {
            return collect();
        }

The method pedigreeCollapseByGenerationData() has 135 lines of code. Current threshold is set to 100. Avoid really long methods.

Open

    public function pedigreeCollapseByGenerationData(): array
    {
        if (!$this->isPdoSupported()) {
            return [];
        }

• Exclude checks
  • Disable engine
  • Disable check

Avoid excessively long variable names like $root_ancestors_contributions. Keep variable name length under 20.

Open

        $root_ancestors_contributions = DB::table('maj_sosa AS sosa')

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $missing_ancestors_by_gen. Keep variable name length under 20.

Open

        $missing_ancestors_by_gen = DB::table('maj_sosa AS sosa')

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $consolidated_ancestors_branches. Keep variable name length under 20.

Open

        $consolidated_ancestors_branches = DB::table('maj_sosa')

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $ancestors_contributions_sum. Keep variable name length under 20.

Open

        $ancestors_contributions_sum = DB::connection()->query()

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $known_ancestors_contributions. Keep variable name length under 20.

Open

        $known_ancestors_contributions = DB::table('maj_sosa AS sosa')

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}