Sign upLogin

jon48/webtrees-lib

View on GitHub
Star

Showing 758 of 758 total issues

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'individualColumns'.
Open

                        'title' => I18N::translate('%s sourced', Registry::elementFactory()->make('INDI:BIRT')->label())
Severity: Minor
Found in app/Module/IsSourced/Hooks/IsSourcedStatusColumnsHook.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
Open

                I18N::translate('The attached module could not be found.'),
Severity: Minor
Found in app/Module/MiscExtensions/Http/RequestHandlers/AdminConfigAction.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
Open

                        'text_yes' => I18N::translate('Running'),
Severity: Minor
Found in app/Module/AdminTasks/Http/RequestHandlers/TasksList.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
Open

            $title = I18N::translate('Certificates for %s', $city);
Severity: Minor
Found in app/Module/Certificates/Http/RequestHandlers/CertificatesList.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method extractDataFromPath uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $this->description = $this->filename;
        }
Severity: Minor
Found in app/Module/Certificates/Model/Certificate.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
Open

            throw new HttpNotFoundException(I18N::translate('The attached module could not be found.'));
Severity: Minor
Found in app/Module/AdminTasks/Http/RequestHandlers/AdminConfigPage.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\FlashMessages' in method 'handle'.
Open

            FlashMessages::addMessage(
                I18N::translate('The attached module could not be found.'),
                'danger'
            );
Severity: Minor
Found in app/Module/AdminTasks/Http/RequestHandlers/TaskEditAction.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Spatie\Color\Factory' in method 'colorsDecoder'.
Open

                \Spatie\Color\Factory::fromString($colors['default'] ?? ''),
Severity: Minor
Found in app/Module/GeoDispersion/Services/GeoAnalysisViewDataService.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'globalTabContent'.
Open

                'message'   =>  I18N::translate('The map could not be loaded.'),
Severity: Minor
Found in app/Module/GeoDispersion/Views/GeoAnalysisMap.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'title'.
Open

        return I18N::translate('Individual names accordion extender');
Severity: Minor
Found in app/Module/Hooks/Hooks/NameAccordionExtenderCollector.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
Open

        FlashMessages::addMessage(I18N::translate('The hook preferences have been updated.'), 'success');
Severity: Minor
Found in app/Module/Hooks/Http/RequestHandlers/ModulesHooksAction.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\FlashMessages' in method 'handle'.
Open

        FlashMessages::addMessage(
            I18N::translate('The preferences for the module “%s” have been updated.', $this->module->title()),
            'success'
        );
Severity: Minor
Found in app/Module/MiscExtensions/Http/RequestHandlers/AdminConfigAction.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'description'.
Open

        return /* I18N: Description of the “MiscExtensions” module */ I18N::translate('Miscellaneous extensions for webtrees.');
Severity: Minor
Found in app/Module/MiscExtensions/MiscExtensionsModule.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
Open

            throw new HttpNotFoundException(I18N::translate('There is no module to handle individual lists.'));
Severity: Minor
Found in app/Module/PatronymicLineage/Http/RequestHandlers/LineagesPage.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
Open

                        I18N::number($schedule->remainingOccurrences()) :
Severity: Minor
Found in app/Module/AdminTasks/Http/RequestHandlers/TasksList.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'run'.
Open

            I18N::init($webmaster->getPreference('language'));
Severity: Minor
Found in app/Module/AdminTasks/Tasks/HealthCheckEmailTask.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\Auth' in method 'handle'.
Open

        $all_trees = $this->tree_service->all()->filter(fn(Tree $tree) => Auth::isManager($tree, $user));
Severity: Minor
Found in app/Module/Certificates/Http/RequestHandlers/AdminConfigPage.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'title'.
Open

        return I18N::translate('All events places by event type');
Severity: Minor
Found in app/Module/GeoDispersion/GeoAnalyses/AllEventsByTypeGeoAnalysis.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method addPlace uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $this->addUnknown();
        }
Severity: Minor
Found in app/Common/GeoDispersion/GeoAnalysis/GeoAnalysisResult.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\Fisharebest\Webtrees\GedcomRecord' in method 'individualsAndFamilies'.
Open

            ->filter(GedcomRecord::accessFilter())
Severity: Minor
Found in app/Module/GeoDispersion/Services/GeoAnalysisDataService.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language