Sign upLogin

jon48/webtrees-lib

View on GitHub
Star

Showing 758 of 758 total issues

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
Open

            $title = I18N::translate('Patronymic Lineages') . ' — ' . I18N::translate('All');
Severity: Minor
Found in app/Module/PatronymicLineage/Http/RequestHandlers/SurnamesList.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\Auth' in method 'results'.
Open

            ->listAncestors($tree, Auth::check() ? Auth::user() : new DefaultUser())
Severity: Minor
Found in app/Module/Sosa/GeoAnalyses/SosaByGenerationGeoAnalysis.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'results'.
Open

                I18N::translate('Generation %s', I18N::number($generation)),
Severity: Minor
Found in app/Module/Sosa/GeoAnalyses/SosaByGenerationGeoAnalysis.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\FlashMessages' in method 'handle'.
Open

                FlashMessages::addMessage(I18N::translate('The root individual has been updated.'));
Severity: Minor
Found in app/Module/Sosa/Http/RequestHandlers/SosaConfigAction.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Brick\Math\BigInteger' in method 'statisticsByGenerations'.
Open

                        BigInteger::of((int) $stats_gen['sosaCount']),
Severity: Minor
Found in app/Module/Sosa/Http/RequestHandlers/SosaStatistics.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
Open

            $title = I18N::translate('Patronymic Lineages') . ' — ' . I18N::translate('All');
Severity: Minor
Found in app/Module/PatronymicLineage/Http/RequestHandlers/SurnamesList.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
Open

            throw new HttpNotFoundException(I18N::translate('The attached module could not be found.'));
Severity: Minor
Found in app/Module/Sosa/Http/RequestHandlers/AncestorsListIndividual.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\Auth' in method 'handle'.
Open

        $user = Auth::check() ? Validator::attributes($request)->user() : new DefaultUser();
Severity: Minor
Found in app/Module/Sosa/Http/RequestHandlers/AncestorsListIndividual.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Brick\Math\BigInteger' in method 'statisticsByGenerations'.
Open

                    BigInteger::of((int) $stats_gen['sosaCount']),
Severity: Minor
Found in app/Module/Sosa/Http/RequestHandlers/SosaStatistics.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\Auth' in method 'sidebarTitle'.
Open

        $user = Auth::check() ? Auth::user() : new DefaultUser();
Severity: Minor
Found in app/Module/Sosa/SosaModule.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\Auth' in method 'getSidebarContent'.
Open

        $sosa_root_xref = $individual->tree()->getUserPreference(Auth::user(), 'MAJ_SOSA_ROOT_ID');
Severity: Minor
Found in app/Module/Sosa/SosaModule.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\Auth' in method 'handle'.
Open

                    (Auth::isAdmin() ? $ex->getMessage() : I18N::translate('Log in as admin for error details'))
Severity: Minor
Found in app/Module/WelcomeBlock/Http/RequestHandlers/MatomoStats.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using empty try-catch blocks in visits.
Open

            } catch (GuzzleException $ex) {
            }
Severity: Minor
Found in app/Module/WelcomeBlock/Services/MatomoStatsService.php by phpmd

EmptyCatchBlock

Since: 2.7.0

Usually empty try-catch is a bad idea because you are silently swallowing an error condition and then continuing execution. Occasionally this may be the right thing to do, but often it's a sign that a developer saw an exception, didn't know what to do about it, and so used an empty catch to silence the problem.

Example

class Foo {

  public function bar()
  {
      try {
          // ...
      } catch (Exception $e) {} // empty catch block
  }
}

Source https://phpmd.org/rules/design.html#emptycatchblock

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
Open

            throw new HttpNotFoundException(I18N::translate('The attached module could not be found.'));
Severity: Minor
Found in app/Module/PatronymicLineage/Http/RequestHandlers/SurnamesList.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
Open

            $title = I18N::translate('Patronymic Lineages') . ' — ' . $initial;
Severity: Minor
Found in app/Module/PatronymicLineage/Http/RequestHandlers/SurnamesList.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
Open

            throw new HttpNotFoundException(I18N::translate('The attached module could not be found.'));
Severity: Minor
Found in app/Module/Sosa/Http/RequestHandlers/AncestorsList.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
Open

            'title'             =>  I18N::translate('Sosa Ancestors'),
Severity: Minor
Found in app/Module/Sosa/Http/RequestHandlers/AncestorsListFamily.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
Open

            I18N::translate('You do not have permission to modify the user.'),
Severity: Minor
Found in app/Module/Sosa/Http/RequestHandlers/SosaComputeAction.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Brick\Math\BigInteger' in method 'statisticsByGenerations'.
Open

                    BigInteger::of($gen_diff),
Severity: Minor
Found in app/Module/Sosa/Http/RequestHandlers/SosaStatistics.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid assigning values to variables in if clauses and the like (line '145', column '18').
Open

    private function addNode(Individual $indi, int $sosa): void
    {
        $birth_year = $indi->getBirthDate()->gregorianYear();
        $birth_year_est = $birth_year === 0 ? $indi->getEstimatedBirthDate()->gregorianYear() : $birth_year;
Severity: Minor
Found in app/Module/Sosa/Services/SosaCalculatorService.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Severity
Category
Status
Source
Language