Sign upLogin

jon48/webtrees-lib

View on GitHub
Star

Showing 758 of 758 total issues

Method handle has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handle(ServerRequestInterface $request): ResponseInterface
    {
        $this->layout = 'layouts/ajax';

        if ($this->module === null) {
Severity: Minor
Found in app/Module/GeoDispersion/Http/RequestHandlers/MapAdapterMapperConfig.php - About 1 hr to fix

    Method handle has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function handle(ServerRequestInterface $request): ResponseInterface
    {
        $tree = Validator::attributes($request)->tree();

        if ($this->module === null) {
    Severity: Minor
    Found in app/Module/GeoDispersion/Http/RequestHandlers/GeoAnalysisViewDeleteAction.php - About 1 hr to fix

      Method map has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function map(Place $place, string $feature_property): ?string
    {
        $location = new PlaceLocation($place->gedcomName());
        $longitude = $location->longitude();
        $latitude = $location->latitude();
      Severity: Minor
      Found in app/Module/GeoDispersion/PlaceMappers/CoordinatesPlaceMapper.php - About 1 hr to fix

        Method topMultipleAncestorsWithNoTies has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function topMultipleAncestorsWithNoTies(int $limit): Collection
    {
        $table_prefix = DB::connection()->getTablePrefix();
        $multiple_ancestors = DB::table('maj_sosa AS sosa')
            ->select('sosa.majs_i_id AS sosa_i_id')
        Severity: Minor
        Found in app/Module/Sosa/Services/SosaStatisticsService.php - About 1 hr to fix

          Method ancestorsDispersionForGeneration has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function ancestorsDispersionForGeneration(int $gen): Collection
    {
        if (!$this->isPdoSupported()) {
            return collect();
        }
          Severity: Minor
          Found in app/Module/Sosa/Services/SosaStatisticsService.php - About 1 hr to fix

            Method handle has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function handle(ServerRequestInterface $request): ResponseInterface
    {
        if ($this->module === null) {
            throw new HttpNotFoundException(I18N::translate('The attached module could not be found.'));
        }
            Severity: Minor
            Found in app/Module/PatronymicLineage/Http/RequestHandlers/SurnamesList.php - About 1 hr to fix

              Method migrateGeoAnalysisMap has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function migrateGeoAnalysisMap(
        stdClass $old_view,
        Tree $tree,
        GeoAnalysisViewDataService $geoview_data_service
    ): bool {
              Severity: Minor
              Found in app/Module/GeoDispersion/Schema/Migration2.php - About 1 hr to fix

                Method handle has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function handle(ServerRequestInterface $request): ResponseInterface
    {
        if ($this->module === null) {
            FlashMessages::addMessage(
                I18N::translate('The attached module could not be found.'),
                Severity: Minor
                Found in app/Module/MiscExtensions/Http/RequestHandlers/AdminConfigAction.php - About 1 hr to fix

                  Function results has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function results(Tree $tree, int $depth): GeoAnalysisResults
    {
        $results = new GeoAnalysisResults();

        foreach ($this->geoanalysis_data_service->individualsAndFamilies($tree) as $record) {
                  Severity: Minor
                  Found in app/Module/GeoDispersion/GeoAnalyses/AllEventsByCenturyGeoAnalysis.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method getLineageRootIndividual has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      private function getLineageRootIndividual(Individual $indi): ?Individual
    {
        $child_families = $indi->childFamilies();
        if ($this->used_indis->get($indi->xref(), false) !== false) {
            return null;
                  Severity: Minor
                  Found in app/Module/PatronymicLineage/Model/LineageBuilder.php - About 1 hr to fix

                    Method listMissingAncestorsAtGeneration has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function listMissingAncestorsAtGeneration(Tree $tree, UserInterface $user, int $gen): Collection
    {
        if ($gen === 1) {
            return collect();
        }
                    Severity: Minor
                    Found in app/Module/Sosa/Services/SosaRecordsService.php - About 1 hr to fix

                      Method handle has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function handle(ServerRequestInterface $request): ResponseInterface
    {
        if ($this->module === null) {
            FlashMessages::addMessage(
                I18N::translate('The attached module could not be found.'),
                      Severity: Minor
                      Found in app/Module/AdminTasks/Http/RequestHandlers/TaskEditAction.php - About 1 hr to fix

                        Method handle has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function handle(ServerRequestInterface $request): ResponseInterface
    {
        if ($this->module === null) {
            throw new HttpNotFoundException(I18N::translate('The attached module could not be found.'));
        }
                        Severity: Minor
                        Found in app/Module/PatronymicLineage/Http/RequestHandlers/LineagesPage.php - About 1 hr to fix

                          Consider simplifying this complex logical expression.
                          Open

                                  if ($fact instanceof Fact && $fact->target() instanceof Source) {
            return $fact->attribute('_ACT');
        } elseif (
            is_array($fact) && count($fact) === 2
            && null !== ($source_elements = $fact[0]) && is_array($source_elements) // @phpstan-ignore-line
                          Severity: Major
                          Found in app/Module/Certificates/Hooks/SourceCertificateIconHook.php - About 1 hr to fix

                            Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                    int $id,
        string $task_id,
        bool $enabled,
        CarbonInterface $last_run,
        bool $last_result,
                            Severity: Major
                            Found in app/Common/Tasks/TaskSchedule.php - About 1 hr to fix

                              Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                      int $id,
        Tree $tree,
        bool $enabled,
        string $description,
        GeoAnalysisInterface $geoanalysis,
                              Severity: Major
                              Found in app/Module/GeoDispersion/Views/AbstractGeoAnalysisView.php - About 1 hr to fix

                                Similar blocks of code found in 5 locations. Consider refactoring.
                                Open

                                <?php

/**
 * webtrees-lib: MyArtJaub library for webtrees
 *
                                Severity: Major
                                Found in app/Module/Hooks/Hooks/SosaMissingDatatablesExtenderCollector.php and 4 other locations - About 55 mins to fix
                                app/Module/Hooks/Hooks/FamilyDatatablesExtenderCollector.php on lines 1..69
                                app/Module/Hooks/Hooks/IndividualDatatablesExtenderCollector.php on lines 1..69
                                app/Module/Hooks/Hooks/SosaFamilyDatatablesExtenderCollector.php on lines 1..69
                                app/Module/Hooks/Hooks/SosaIndividualDatatablesExtenderCollector.php on lines 1..69

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 99.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 5 locations. Consider refactoring.
                                Open

                                <?php

/**
 * webtrees-lib: MyArtJaub library for webtrees
 *
                                Severity: Major
                                Found in app/Module/Hooks/Hooks/IndividualDatatablesExtenderCollector.php and 4 other locations - About 55 mins to fix
                                app/Module/Hooks/Hooks/FamilyDatatablesExtenderCollector.php on lines 1..69
                                app/Module/Hooks/Hooks/SosaFamilyDatatablesExtenderCollector.php on lines 1..69
                                app/Module/Hooks/Hooks/SosaIndividualDatatablesExtenderCollector.php on lines 1..69
                                app/Module/Hooks/Hooks/SosaMissingDatatablesExtenderCollector.php on lines 1..69

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 99.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 5 locations. Consider refactoring.
                                Open

                                <?php

/**
 * webtrees-lib: MyArtJaub library for webtrees
 *
                                Severity: Major
                                Found in app/Module/Hooks/Hooks/SosaFamilyDatatablesExtenderCollector.php and 4 other locations - About 55 mins to fix
                                app/Module/Hooks/Hooks/FamilyDatatablesExtenderCollector.php on lines 1..69
                                app/Module/Hooks/Hooks/IndividualDatatablesExtenderCollector.php on lines 1..69
                                app/Module/Hooks/Hooks/SosaIndividualDatatablesExtenderCollector.php on lines 1..69
                                app/Module/Hooks/Hooks/SosaMissingDatatablesExtenderCollector.php on lines 1..69

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 99.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 5 locations. Consider refactoring.
                                Open

                                <?php

/**
 * webtrees-lib: MyArtJaub library for webtrees
 *
                                Severity: Major
                                Found in app/Module/Hooks/Hooks/FamilyDatatablesExtenderCollector.php and 4 other locations - About 55 mins to fix
                                app/Module/Hooks/Hooks/IndividualDatatablesExtenderCollector.php on lines 1..69
                                app/Module/Hooks/Hooks/SosaFamilyDatatablesExtenderCollector.php on lines 1..69
                                app/Module/Hooks/Hooks/SosaIndividualDatatablesExtenderCollector.php on lines 1..69
                                app/Module/Hooks/Hooks/SosaMissingDatatablesExtenderCollector.php on lines 1..69

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 99.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Severity
                                Category
                                Status
                                Source
                                Language