jonnyhaynes/inline-svg

View on GitHub

Showing 4 of 4 total issues

Function inliner has 100 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  var inliner = function (cb) {
    var svgs = getAll();
    var callback = after(svgs.length, cb);

    Array.prototype.forEach.call(svgs, function (svg, i) {
Severity: Major
Found in src/inlineSVG.js - About 4 hrs to fix

    Function onload has 86 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          request.onload = function () {
            if (request.status >= 200 && request.status < 400) {
              // Setup a parser to convert the response to text/xml in order for it
              // to be manipulated and changed
              var parser = new DOMParser(),
    Severity: Major
    Found in src/inlineSVG.js - About 3 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                    var getTitleId = function () {
                      if (inlinedSVG.getElementsByTagName('title').length > 0) {
                        var titleId = inlinedSVG.getElementsByTagName('title')[0].getAttribute('id');
                        return titleId;
                      } else {
      Severity: Major
      Found in src/inlineSVG.js and 1 other location - About 1 hr to fix
      src/inlineSVG.js on lines 196..203

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  var getDescId = function () {
                    if (inlinedSVG.getElementsByTagName('desc').length > 0) {
                      var descId = inlinedSVG.getElementsByTagName('desc')[0].getAttribute('id');
                      return descId;
                    } else {
      Severity: Major
      Found in src/inlineSVG.js and 1 other location - About 1 hr to fix
      src/inlineSVG.js on lines 165..172

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language