jordansne/ntwitbot

View on GitHub

Showing 5 of 12 total issues

Function retrieveForNew has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    retrieveForNew(params, tweetsLeft, tweetsRetrieved) {
        // Copy object to allow for proper unit testing
        const request = Object.assign({}, params);

        // If first request..
Severity: Major
Found in src/retrieve.js - About 2 hrs to fix

    Function retrieveForExisting has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        retrieveForExisting(params, tweetsRetrieved) {
            // Copy object to allow for proper unit testing
            const request = Object.assign({}, params);
            const firstReq = !request.hasOwnProperty('max_id');
    
    
    Severity: Minor
    Found in src/retrieve.js - About 1 hr to fix

      Function generateTweet has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          generateTweet(wordDB) {
              let wordStack, firstWord = 0;
              const firstWords = this.getFirstWords(wordDB);
      
              let done = false;
      Severity: Minor
      Found in src/generate.js - About 1 hr to fix

        Function generateTweet has a Cognitive Complexity of 14 (exceeds 10 allowed). Consider refactoring.
        Open

            generateTweet(wordDB) {
                let wordStack, firstWord = 0;
                const firstWords = this.getFirstWords(wordDB);
        
                let done = false;
        Severity: Minor
        Found in src/generate.js - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getPossibleMoves has a Cognitive Complexity of 14 (exceeds 10 allowed). Consider refactoring.
        Open

            getPossibleMoves(wordDB, wordStack) {
                const nextMoves = [];
                const key = this.keyOf(wordStack);
        
                if (wordStack.length === 0) {
        Severity: Minor
        Found in src/generate.js - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language