Sign upLogin

jordifierro/rails-api-base

View on GitHub
Star
app/controllers/api/v1/sessions_controller.rb

Summary

Maintainability
A
0 mins
Test Coverage

Use find_by instead of dynamic find_by_email.
Open

        user = User.find_by_email(params[:user][:email])
Severity: Minor
Found in app/controllers/api/v1/sessions_controller.rb by rubocop

This cop checks dynamic find_by_* methods. Use find_by instead of dynamic method. See. https://github.com/bbatsov/rails-style-guide#find_by

Example:

# bad
User.find_by_name(name)

# bad
User.find_by_name_and_email(name)

# bad
User.find_by_email!(name)

# good
User.find_by(name: name)

# good
User.find_by(name: name, email: email)

# good
User.find_by!(email: email)

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

        if user && user.authenticate(params[:user][:password])
Severity: Minor
Found in app/controllers/api/v1/sessions_controller.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

There are no issues that match your filters.

Category
Status