Sign upLogin

josephholsten/discodactyl

View on GitHub
Star
lib/discodactyl/resource_discovery.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method get_uris_by_rel has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

      def get_uris_by_rel(uri, rel, params = {})
        begin
          uri = URI.parse(uri.to_s) unless uri.respond_to?('open')
          Discodactyl.log.debug "Getting uris for uri #{uri.inspect} by rel #{rel.inspect} with params #{params.inspect}" if Discodactyl.log
          resource = uri.open
Severity: Minor
Found in lib/discodactyl/resource_discovery.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_uris_by_rel has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def get_uris_by_rel(uri, rel, params = {})
        begin
          uri = URI.parse(uri.to_s) unless uri.respond_to?('open')
          Discodactyl.log.debug "Getting uris for uri #{uri.inspect} by rel #{rel.inspect} with params #{params.inspect}" if Discodactyl.log
          resource = uri.open
Severity: Minor
Found in lib/discodactyl/resource_discovery.rb - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status