Showing 6 of 6 total issues
Cyclomatic complexity for default_request is too high. [9/6] Open
Open
def default_request(env)
@app.call(env).on_complete do |response|
case response[:status]
when 400
raise Taric::FaradayMiddleware::BadRequest, 'Bad parameter, check API documentation'- Read upRead up
- Exclude checks
This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.
Avoid parameter lists longer than 5 parameters. [8/5] Open
Open
def matchlist(account_id:, begin_time: nil, end_index: nil, season: nil, champion: nil, begin_index: nil, queue: nil, end_time: nil)- Read upRead up
- Exclude checks
This cop checks for methods with too many parameters. The maximum number of parameters is configurable. Keyword arguments can optionally be excluded from the total count.
TODO found Open
Open
TODO: finish writing this crap :p- Exclude checks
HACK found Open
Open
(TODO, FIXME, OPTIMIZE, HACK, REVIEW).- Exclude checks
TODO found Open
Open
(TODO, FIXME, OPTIMIZE, HACK, REVIEW).- Exclude checks
FIXME found Open
Open
(TODO, FIXME, OPTIMIZE, HACK, REVIEW).- Exclude checks