Sign upLogin

joyent/node

View on GitHub
Star
deps/npm/lib/utils/tar.js

Summary

Maintainability
D
2 days
Test Coverage

Function gunzTarPerm has 131 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function gunzTarPerm (tarball, target, dMode, fMode, uid, gid, cb_) {
  if (!dMode) dMode = npm.modes.exec
  if (!fMode) fMode = npm.modes.file
  log.silly("gunzTarPerm", "modes", [dMode.toString(8), fMode.toString(8)])
Severity: Major
Found in deps/npm/lib/utils/tar.js - About 5 hrs to fix

    Function gunzTarPerm has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
    Open

    function gunzTarPerm (tarball, target, dMode, fMode, uid, gid, cb_) {
  if (!dMode) dMode = npm.modes.exec
  if (!fMode) fMode = npm.modes.file
  log.silly("gunzTarPerm", "modes", [dMode.toString(8), fMode.toString(8)])
    Severity: Minor
    Found in deps/npm/lib/utils/tar.js - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function OD has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        .on("data", function OD (c) {
      // detect what it is.
      // Then, depending on that, we'll figure out whether it's
      // a single-file module, gzipped tarball, or naked tarball.
      // gzipped files all start with 1f8b08
    Severity: Major
    Found in deps/npm/lib/utils/tar.js - About 2 hrs to fix

      Function gunzTarPerm has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      function gunzTarPerm (tarball, target, dMode, fMode, uid, gid, cb_) {
      Severity: Major
      Found in deps/npm/lib/utils/tar.js - About 50 mins to fix

        Function unpack_ has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function unpack_ ( tarball, unpackTarget, dMode, fMode, uid, gid, cb ) {
        Severity: Major
        Found in deps/npm/lib/utils/tar.js - About 50 mins to fix

          Function unpack has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function unpack (tarball, unpackTarget, dMode, fMode, uid, gid, cb) {
          Severity: Major
          Found in deps/npm/lib/utils/tar.js - About 50 mins to fix

            Function pack has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            function pack (tarball, folder, pkg, dfc, cb) {
            Severity: Minor
            Found in deps/npm/lib/utils/tar.js - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                if (process.platform !== "win32" &&
      typeof uid === "number" &&
      typeof gid === "number") {
    extractOpts.uid = uid
    extractOpts.gid = gid
              Severity: Major
              Found in deps/npm/lib/utils/tar.js and 1 other location - About 1 hr to fix
              deps/npm/lib/utils/tar.js on lines 246..251

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 57.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (process.platform !== "win32" &&
            typeof uid === "number" &&
            typeof gid === "number") {
          jsOpts.uid = uid
          jsOpts.gid = gid
              Severity: Major
              Found in deps/npm/lib/utils/tar.js and 1 other location - About 1 hr to fix
              deps/npm/lib/utils/tar.js on lines 164..169

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 57.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status