deps/v8/build/landmine_utils.py

Summary

Maintainability
B
5 hrs
Test Coverage

Function builder has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

def builder():
  """
  Returns a string representing the build engine (not compiler) to use.
  Possible values: 'make', 'ninja', 'xcode', 'msvs', 'scons'
  """
Severity: Minor
Found in deps/v8/build/landmine_utils.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function memoize has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

def memoize(default=None):
  """This decorator caches the return value of a parameterless pure function"""
  def memoizer(func):
    val = []
    @functools.wraps(func)
Severity: Minor
Found in deps/v8/build/landmine_utils.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function platform has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def platform():
  """
  Returns a string representing the platform this build is targetted for.
  Possible values: 'win', 'mac', 'linux', 'ios', 'android'
  """
Severity: Minor
Found in deps/v8/build/landmine_utils.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

      return 'make'
Severity: Major
Found in deps/v8/build/landmine_utils.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

          return 'msvs'
    Severity: Major
    Found in deps/v8/build/landmine_utils.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return 'xcode'
      Severity: Major
      Found in deps/v8/build/landmine_utils.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return 'mac'
        Severity: Major
        Found in deps/v8/build/landmine_utils.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return 'xcode'
          Severity: Major
          Found in deps/v8/build/landmine_utils.py - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status