Showing 2,859 of 2,859 total issues
Similar blocks of code found in 2 locations. Consider refactoring. Open
if (!npm.config.get("global")) {
fg = fg.map(function (g) {
return [g, "-g"]
})
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 48.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function start
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
exports.start = function(prompt, source, eval_, useGlobal, ignoreUndefined) {
Function REPLServer
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
function REPLServer(prompt, stream, eval_, useGlobal, ignoreUndefined) {
Function pbkdf2Sync
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
exports.pbkdf2Sync = function(password, salt, iterations, keylen, digest) {
Function readableAddChunk
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
function readableAddChunk(stream, state, chunk, encoding, addToFront) {
Function _listen2
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Server.prototype._listen2 = function(address, port, addressType, backlog, fd) {
Function formatArray
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
function formatArray(ctx, value, recurseTimes, visibleKeys, keys) {
Function afterConnect
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
function afterConnect(status, handle, req, readable, writable) {
Function fail
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
function fail(actual, expected, message, operator, stackStartFunction) {
Function readSync
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
fs.readSync = function(fd, buffer, offset, length, position) {
Function SecurePair
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
function SecurePair(context, isServer, requestCert, rejectUnauthorized,
options) {
Function writeSync
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
fs.writeSync = function(fd, buffer, offset, length, position) {
Function streamWrite
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
function streamWrite(algo, message, encoding, writes, len) {
Function legacyWrite
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
function legacyWrite(algo, message, encoding, writes, len) {
Function initialize
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
initialize : function(color, reflection, refraction, transparency, gloss) {
Function onwriteError
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
function onwriteError(stream, state, sync, er, cb) {
Function legacyWrite
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
function legacyWrite(alice, bob, message, encoding, writes) {
Function streamWrite
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
function streamWrite(alice, bob, message, encoding, writes) {
Function writeOrBuffer
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
function writeOrBuffer(stream, state, chunk, encoding, cb) {
Function printEntries
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
profile, totalTicks, nonLibTicks, filterP, callback) {