Sign upLogin

joyent/node

View on GitHub
Star
tools/closure_linter/closure_linter/javascriptstatetracker.py

Summary

Maintainability
C
7 hrs
Test Coverage

Function GetClosurizedNamespace has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

  def GetClosurizedNamespace(self, identifier):
    """Given an identifier, returns the namespace that identifier is from.

    Args:
      identifier: The identifier to extract a namespace from.
Severity: Minor
Found in tools/closure_linter/closure_linter/javascriptstatetracker.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function HandleToken has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  def HandleToken(self, token, last_non_space_token):
    """Handles the given token and updates state.

    Args:
      token: The token to handle.
Severity: Minor
Found in tools/closure_linter/closure_linter/javascriptstatetracker.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    return None
Severity: Major
Found in tools/closure_linter/closure_linter/javascriptstatetracker.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return '.'.join(parts)
    Severity: Major
    Found in tools/closure_linter/closure_linter/javascriptstatetracker.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return '.'.join(parts[:i])
      Severity: Major
      Found in tools/closure_linter/closure_linter/javascriptstatetracker.py - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status