Sign upLogin

joyent/node

View on GitHub
Star
tools/closure_linter/closure_linter/tokenutil.py

Summary

Maintainability
D
1 day
Test Coverage

Function CustomSearch has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

def CustomSearch(start_token, func, end_func=None, distance=None,
                 reverse=False):
  """Returns the first token where func is True within distance of this token.

  Args:
Severity: Minor
Found in tools/closure_linter/closure_linter/tokenutil.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function InsertTokenAfter has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

def InsertTokenAfter(new_token, token):
  """Insert new_token after token

  Args:
    new_token: A token to be added to the stream
Severity: Minor
Found in tools/closure_linter/closure_linter/tokenutil.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function CustomSearch has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def CustomSearch(start_token, func, end_func=None, distance=None,
Severity: Minor
Found in tools/closure_linter/closure_linter/tokenutil.py - About 35 mins to fix

    Function SearchUntil has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def SearchUntil(start_token, token_types, end_types, distance=None,
    Severity: Minor
    Found in tools/closure_linter/closure_linter/tokenutil.py - About 35 mins to fix

      Avoid too many return statements within this function.
      Open

        return None
      Severity: Major
      Found in tools/closure_linter/closure_linter/tokenutil.py - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          if reverse:
    while token and (distance is None or distance > 0):
      previous = token.previous
      if previous:
        if func(previous):
        Severity: Major
        Found in tools/closure_linter/closure_linter/tokenutil.py and 1 other location - About 5 hrs to fix
        tools/closure_linter/closure_linter/tokenutil.py on lines 65..89

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 86.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status