Sign upLogin

joyent/node

View on GitHub
Star
tools/gyp/pylib/gyp/generator/eclipse.py

Summary

Maintainability
D
2 days
Test Coverage

Function GetAllIncludeDirectories has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
Open

def GetAllIncludeDirectories(target_list, target_dicts,
                             shared_intermediate_dirs, config_name, params):
  """Calculate the set of include directories to be used.

  Returns:
Severity: Minor
Found in tools/gyp/pylib/gyp/generator/eclipse.py - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function GetAllDefines has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

def GetAllDefines(target_list, target_dicts, data, config_name, params):
  """Calculate the defines for a project.

  Returns:
    A dict that includes explict defines declared in gyp files along with all of
Severity: Minor
Found in tools/gyp/pylib/gyp/generator/eclipse.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

          for include_dir in include_dirs:
            include_dir = include_dir.replace('$SHARED_INTERMEDIATE_DIR',
                                              shared_intermediate_dir)
            if not os.path.isabs(include_dir):
              base_dir = os.path.dirname(target_name)
Severity: Major
Found in tools/gyp/pylib/gyp/generator/eclipse.py - About 45 mins to fix

    Function GetAllIncludeDirectories has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def GetAllIncludeDirectories(target_list, target_dicts,
    Severity: Minor
    Found in tools/gyp/pylib/gyp/generator/eclipse.py - About 35 mins to fix

      Function GenerateOutputForConfig has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def GenerateOutputForConfig(target_list, target_dicts, data, params,
      Severity: Minor
      Found in tools/gyp/pylib/gyp/generator/eclipse.py - About 35 mins to fix

        Function GetAllDefines has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def GetAllDefines(target_list, target_dicts, data, config_name, params):
        Severity: Minor
        Found in tools/gyp/pylib/gyp/generator/eclipse.py - About 35 mins to fix

          Function GetCompilerPath has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          def GetCompilerPath(target_list, target_dicts, data):
  """Determine a command that can be used to invoke the compiler.

  Returns:
    If this is a gyp project that has explicit make settings, try to determine
          Severity: Minor
          Found in tools/gyp/pylib/gyp/generator/eclipse.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            if flavor == 'win':
    # Copy additional generator configuration data from VS, which is shared
    # by the Eclipse generator.
    import gyp.generator.msvs as msvs_generator
    generator_additional_non_configuration_keys = getattr(msvs_generator,
          Severity: Major
          Found in tools/gyp/pylib/gyp/generator/eclipse.py and 1 other location - About 1 hr to fix
          tools/gyp/pylib/gyp/generator/dump_dependency_json.py on lines 39..48

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          def CalculateGeneratorInputInfo(params):
  """Calculate the generator specific info that gets fed to input (called by
  gyp)."""
  generator_flags = params.get('generator_flags', {})
  if generator_flags.get('adjust_static_libraries', False):
          Severity: Major
          Found in tools/gyp/pylib/gyp/generator/eclipse.py and 1 other location - About 1 hr to fix
          tools/gyp/pylib/gyp/generator/dump_dependency_json.py on lines 51..57

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 39.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status