Sign upLogin

jplusplus/the-accountant

View on GitHub
Star
src/components/game/game.service.js

Summary

Maintainability
F
3 days
Test Coverage

Function gameService has 247 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function gameService($log, $rootScope, Step, Var, Ending, Character, I18n, memoizeMixin) {
  // Symbols declarion for private attributes and methods
  const _meta = Symbol('meta');
  const _vars = Symbol('vars');
  const _history = Symbol('history');
Severity: Major
Found in src/components/game/game.service.js - About 1 day to fix

    Game has 53 functions (exceeds 20 allowed). Consider refactoring.
    Open

      class Game {
    constructor(meta) {
      // Load meta data
      this[_meta] = angular.copy(meta || game);
      // Build step using meta data
    Severity: Major
    Found in src/components/game/game.service.js - About 7 hrs to fix

      Function gameService has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
      Open

      function gameService($log, $rootScope, Step, Var, Ending, Character, I18n, memoizeMixin) {
  // Symbols declarion for private attributes and methods
  const _meta = Symbol('meta');
  const _vars = Symbol('vars');
  const _history = Symbol('history');
      Severity: Minor
      Found in src/components/game/game.service.js - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File game.service.js has 252 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      export default gameService;
import _ from 'lodash';
import game from './game.json';

/** @ngInject */
      Severity: Minor
      Found in src/components/game/game.service.js - About 2 hrs to fix

        Function gameService has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function gameService($log, $rootScope, Step, Var, Ending, Character, I18n, memoizeMixin) {
        Severity: Major
        Found in src/components/game/game.service.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              finalSlice() {
      this.lastStack.finalSlice();
      // Invalidate the journey cache key
      this.invalidateJourney();
      // Emit an event
          Severity: Major
          Found in src/components/game/game.service.js and 1 other location - About 1 hr to fix
          src/components/game/game.service.js on lines 128..134

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              continue() {
      this.lastStack.continue();
      // Invalidate the journey cache key
      this.invalidateJourney();
      // Emit an event
          Severity: Major
          Found in src/components/game/game.service.js and 1 other location - About 1 hr to fix
          src/components/game/game.service.js on lines 135..141

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                this[_meta].endings = _.castArray(this[_meta].endings).map(meta => new Ending(meta, this));
          Severity: Minor
          Found in src/components/game/game.service.js and 1 other location - About 50 mins to fix
          src/components/game/game.service.js on lines 18..18

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                this[_meta].steps = _.castArray(this[_meta].steps).map(meta => new Step(meta, this));
          Severity: Minor
          Found in src/components/game/game.service.js and 1 other location - About 50 mins to fix
          src/components/game/game.service.js on lines 20..20

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status