Showing 3 of 3 total issues
Method generate!
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
def self.generate!(destination_url, owner: nil, custom_key: nil, expires_at: nil, fresh: false, category: nil)
# if we get a shortened_url object with a different owner, generate
# new one for the new owner. Otherwise return same object
if destination_url.is_a? Shortener::ShortenedUrl
if destination_url.owner == owner
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method shorten_url
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def shorten_url(url)
if url.length > @length_threshold && ! @not_shorten.any?{|r| r =~ url}
short_url = Shortener::ShortenedUrl.generate!(url)
File.join(@base_url, short_url.unique_key)
else
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method generate_unique_key
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def generate_unique_key(retries = Shortener.persist_retries)
begin
self.unique_key = custom_key || self.class.unique_key_candidate
self.custom_key = nil
end while self.class.unscoped.exists?(unique_key: unique_key)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"