Sign upLogin

jpmckinney/multi_mail

View on GitHub
Star
lib/multi_mail/receiver/base.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method parse has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

        def parse(raw)
          case raw
          when String
            begin
              JSON.load(raw)
Severity: Minor
Found in lib/multi_mail/receiver/base.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def parse(raw)
          case raw
          when String
            begin
              JSON.load(raw)
Severity: Minor
Found in lib/multi_mail/receiver/base.rb - About 1 hr to fix

    Method condense has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

            def condense(message)
          if message.multipart? && message.parts.any?(&:multipart?)
            # Get the message parts as a flat array.
            result = flatten(Mail.new, message.parts.dup)
    Severity: Minor
    Found in lib/multi_mail/receiver/base.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status