jpmckinney/pupa-ruby

View on GitHub

Showing 17 of 17 total issues

Method opts has 76 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def opts
      @opts ||= OptionParser.new do |opts|
        opts.program_name = File.basename($PROGRAM_NAME)
        opts.banner = "Usage: #{opts.program_name}"

Severity: Major
Found in lib/pupa/runner.rb - About 3 hrs to fix

    Method import has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        def import
          @report[:import] = {}
    
          objects = deduplicate(load_scraped_objects)
    
    
    Severity: Minor
    Found in lib/pupa/processor.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method run has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def run(args, overrides = {})
          rest = opts.parse!(args)
    
          @options = OpenStruct.new(options.to_h.merge(overrides))
    
    
    Severity: Major
    Found in lib/pupa/runner.rb - About 2 hrs to fix

      Method new has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

            def self.new(cache_dir: nil, expires_in: 86400, value_max_bytes: 1048576, memcached_username: nil, memcached_password: nil, level: 'INFO', logdev: STDOUT, faraday_options: {}) # 1 day
              follow_redirects = faraday_options.delete(:follow_redirects)
      
              Faraday.new(faraday_options) do |connection|
                connection.request :url_encoded
      Severity: Minor
      Found in lib/pupa/processor/client.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method run has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          def run(args, overrides = {})
            rest = opts.parse!(args)
      
            @options = OpenStruct.new(options.to_h.merge(overrides))
      
      
      Severity: Minor
      Found in lib/pupa/runner.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method import has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def import
            @report[:import] = {}
      
            objects = deduplicate(load_scraped_objects)
      
      
      Severity: Minor
      Found in lib/pupa/processor.rb - About 1 hr to fix

        Method new has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def self.new(cache_dir: nil, expires_in: 86400, value_max_bytes: 1048576, memcached_username: nil, memcached_password: nil, level: 'INFO', logdev: STDOUT, faraday_options: {}) # 1 day
                follow_redirects = faraday_options.delete(:follow_redirects)
        
                Faraday.new(faraday_options) do |connection|
                  connection.request :url_encoded
        Severity: Minor
        Found in lib/pupa/processor/client.rb - About 1 hr to fix

          Method add_name has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def add_name(name, start_date: nil, end_date: nil, note: nil, family_name: nil, given_name: nil, additional_name: nil, honorific_prefix: nil, honorific_suffix: nil, patronymic_name: nil)
                  data = {name: name}
                  if start_date
                    data[:start_date] = start_date
                  end
          Severity: Minor
          Found in lib/pupa/models/concerns/nameable.rb - About 1 hr to fix

            Method save has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    def save(object)
                      fingerprint = symbolize_keys(object.fingerprint) # Sequel needs symbols
                      selector = if fingerprint.key?(:$or) && fingerprint.size == 1
                        Sequel.or(reject_subdocument_criteria(fingerprint[:$or]))
                      else
            Severity: Minor
            Found in lib/pupa/processor/connection_adapters/postgresql_adapter.rb - About 1 hr to fix

              Method add_name has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                    def add_name(name, start_date: nil, end_date: nil, note: nil, family_name: nil, given_name: nil, additional_name: nil, honorific_prefix: nil, honorific_suffix: nil, patronymic_name: nil)
                      data = {name: name}
                      if start_date
                        data[:start_date] = start_date
                      end
              Severity: Minor
              Found in lib/pupa/models/concerns/nameable.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                module Concerns
                  # Adds the Popolo `sources` property to a model.
                  module Sourceable
                    extend ActiveSupport::Concern
              
              
              Severity: Minor
              Found in lib/pupa/models/concerns/sourceable.rb and 1 other location - About 50 mins to fix
              lib/pupa/models/concerns/linkable.rb on lines 2..34

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 42.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                module Concerns
                  # Adds the Popolo `links` property to a model.
                  module Linkable
                    extend ActiveSupport::Concern
              
              
              Severity: Minor
              Found in lib/pupa/models/concerns/linkable.rb and 1 other location - About 50 mins to fix
              lib/pupa/models/concerns/sourceable.rb on lines 2..34

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 42.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method to_h has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  def to_h(persist: false)
                    {}.tap do |hash|
                      (persist ? properties - foreign_objects : properties).each do |property|
                        value = self[property]
                        if value == false || value.present?
              Severity: Minor
              Found in lib/pupa/models/model.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method reject_subdocument_criteria has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                      def reject_subdocument_criteria(object)
                        case object
                        when Hash
                          array = []
                          object.each do |key,value|
              Severity: Minor
              Found in lib/pupa/processor/connection_adapters/postgresql_adapter.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method resolve_foreign_objects has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def resolve_foreign_objects(object, map)
                    object.foreign_objects.each do |property|
                      value = object[property]
                      if value.present?
                        foreign_object = ForeignObject.new(value)
              Severity: Minor
              Found in lib/pupa/processor.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method resolve_foreign_keys has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def resolve_foreign_keys(object, map)
                    object.foreign_keys.each do |property|
                      value = object[property]
                      if value
                        if map.key?(value)
              Severity: Minor
              Found in lib/pupa/processor.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method add_contact_detail has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                    def add_contact_detail(type, value, note: nil, label: nil, valid_from: nil, valid_until: nil)
                      data = {type: type, value: value}
                      if note
                        data[:note] = note
                      end
              Severity: Minor
              Found in lib/pupa/models/concerns/contactable.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language