Sign upLogin

jstacoder/flask-tasks

View on GitHub
Star
flask_tasks/tasks/api/views.py

Summary

Maintainability
B
4 hrs
Test Coverage

Function post has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    def post(self):
        default_result = jsonify(success=False,error='there was an error')
        updated = False
        result = None
        self._process_post()
Severity: Minor
Found in flask_tasks/tasks/api/views.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if not updated:
                            updated = True
                            result = jsonify(success=True,error=None)
            send_msg('update:task',task.save().to_json())
Severity: Major
Found in flask_tasks/tasks/api/views.py - About 45 mins to fix

    Function post has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def post(self):
        self._process_post()
        success = None
        try:
            task = Task.query.get(self.data.get('item_id'))
    Severity: Minor
    Found in flask_tasks/tasks/api/views.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status