jsverify/jsverify

View on GitHub

Showing 52 of 52 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  jsc.property("async evaluation...", jsc.fun(jsc.nat), jsc.json, jsc.nat(20), (f, x, t) => {
    const sync = f(x);

    return new Promise(resolve => {
      setTimeout(() => resolve(f(x)), t);
Severity: Major
Found in test-ts/example.ts and 1 other location - About 1 hr to fix
test-ts/example.ts on lines 11..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function check has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function check(property, opts) {
  opts = opts || {};
  opts.size = opts.size || 50;
  opts.tests = opts.tests || 100;
  opts.quiet = opts.quiet || false;
Severity: Minor
Found in lib/jsverify.js - About 1 hr to fix

    Function loop has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function loop(a, b, n) {
        if (isNaN(a) && isNaN(b)) {
          return true;
        }
    
    
    Severity: Minor
    Found in lib/utils.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      Left.prototype.isEqual = function leftIsEqual(other) {
        assert(other instanceof Left || other instanceof Right, "isEqual: `other` parameter should be either");
        return other instanceof Left && this.value === other.value;
      };
      Severity: Major
      Found in lib/either.js and 1 other location - About 1 hr to fix
      lib/either.js on lines 52..55

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      Right.prototype.isEqual = function rightIsEqual(other) {
        assert(other instanceof Left || other instanceof Right, "isEqual: `other` parameter should be either");
        return other instanceof Right && this.value === other.value;
      };
      Severity: Major
      Found in lib/either.js and 1 other location - About 1 hr to fix
      lib/either.js on lines 47..50

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function suchthat has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      function suchthat(arb, userenv, predicate) {
        var env;
        if (arguments.length === 2) {
          predicate = userenv;
          env = environment;
      Severity: Minor
      Found in lib/suchthat.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function suchthat has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function suchthat(arb, userenv, predicate) {
        var env;
        if (arguments.length === 2) {
          predicate = userenv;
          env = environment;
      Severity: Minor
      Found in lib/suchthat.js - About 1 hr to fix

        Function isEqual has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function isEqual(a, b) {
          var i;
        
          if (isNaN(a) && isNaN(b)) {
            return true;
        Severity: Minor
        Found in lib/utils.js - About 1 hr to fix

          Function redundancyProp has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

          function redundancyProp(input, output) {
            var len = output.length;
            for (var i = 0; i < len; i++) {
              for (var j = 0; j < len; j++) {
                if (i === j) {
          Severity: Minor
          Found in examples/set-cover/set-cover.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function redundancyProp has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

          function redundancyProp(input, output) {
            var len = output.length;
            for (var i = 0; i < len; i++) {
              for (var j = 0; j < len; j++) {
                if (i === j) {
          Severity: Minor
          Found in examples/set-cover-dsl/set-cover.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function shrinkResult has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function shrinkResult(arbs, x, test, size, shrinksN, exc, transform) {
          Severity: Major
          Found in lib/jsverify.js - About 50 mins to fix

            Function integer has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

            var integer = numeric(function integer(maxsize) {
              return {
                generator: generator.bless(function (size) {
                  size = maxsize === undefined ? size : maxsize;
                  return random(-size, size);
            Severity: Minor
            Found in lib/primitive.js - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function formatFailedCase has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

            function formatFailedCase(r, state, includeStack) {
              var msg = "Failed after " + r.tests + " tests and " + r.shrinks + " shrinks. ";
              msg += "rngState: " + (r.rngState || state) + "; ";
              msg += "Counterexample: " + r.counterexamplestr + "; ";
              if (r.exc) {
            Severity: Minor
            Found in lib/jsverify.js - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function throws has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

            function throws(block, error, message) {
              assert(error === undefined || typeof error === "function", "throws: error parameter must be a constructor");
              assert(message === undefined || typeof message === "string", "throws: message parameter must be a string");
            
              try {
            Severity: Minor
            Found in lib/jsverify.js - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            jsc.check(jsc.forall(array2Nat, jsc.nat(), function (ls, split) { return optimalProp(ls, greedy(ls), split); }), jscOptions);
            Severity: Minor
            Found in examples/set-cover/set-cover.js and 1 other location - About 40 mins to fix
            examples/set-cover/set-cover.js on lines 239..239

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            jsc.check(jsc.forall(array2Nat, jsc.nat(), function (ls, split) { return optimalProp(ls, better(ls), split); }), jscOptions);
            Severity: Minor
            Found in examples/set-cover/set-cover.js and 1 other location - About 40 mins to fix
            examples/set-cover/set-cover.js on lines 231..231

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Avoid too many return statements within this function.
            Open

                    return false;
            Severity: Major
            Found in lib/utils.js - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  jsc.property("foo", jsc.constant("bar"), function () {
                    return library.resolve(false).delay(10);
                  });
              Severity: Minor
              Found in fail/promise.js and 1 other location - About 30 mins to fix
              fail/issue87.js on lines 17..19

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Avoid too many return statements within this function.
              Open

                    return false;
              Severity: Major
              Found in lib/utils.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return false;
                Severity: Major
                Found in lib/utils.js - About 30 mins to fix
                  Severity
                  Category
                  Status
                  Source
                  Language