juice-shop/juice-shop-ctf

View on GitHub

Showing 6 of 7 total issues

Function createRtbExport has a Cognitive Complexity of 52 (exceeds 7 allowed). Consider refactoring.
Open

Severity: Minor
Found in lib/generators/rtb.js - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function generateCTFExport has 43 lines of code (exceeds 30 allowed). Consider refactoring.
Open

async function generateCTFExport (ctfFramework, challenges, settings) {
  async function ctfdExport () {
    const ctfdData = await createCtfdExport(challenges, settings)
    const ctfdFile = await writeToCtfdZip(ctfdData, settings.outputLocation)

Severity: Minor
Found in lib/generators/index.js - About 1 hr to fix

    Function juiceShopCtfCli has 33 lines of code (exceeds 30 allowed). Consider refactoring.
    Open

    const juiceShopCtfCli = async () => {
      console.log()
      console.log(`Generate ${'OWASP Juice Shop'.bold} challenge archive for setting up ${options.ctfdFramework.bold}, ${options.fbctfFramework.bold} or ${options.rtbFramework.bold} score server`)
    
      try {
    Severity: Minor
    Found in index.js - About 1 hr to fix

      Function createCtfdExport has a Cognitive Complexity of 12 (exceeds 7 allowed). Consider refactoring.
      Open

      function createCtfdExport (challenges, { insertHints, insertHintUrls, insertHintSnippets, ctfKey, vulnSnippets }) {
        function insertChallenge (data, challenge) {
          const score = calculateScore(challenge.difficulty)
          challenge.description = challenge.description.replace('`xss`', '`xss`')
          data.challenges.results.push(
      Severity: Minor
      Found in lib/generators/ctfd.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function insertHintSnippet has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        function insertHintSnippet ({ hints }, challenge, snippet, hasTextHintPrerequisite, hasHintUrlPrerequisite) {
      Severity: Minor
      Found in lib/generators/ctfd.js - About 35 mins to fix

        Function createFbctfExport has a Cognitive Complexity of 9 (exceeds 7 allowed). Consider refactoring.
        Open

        async function createFbctfExport (challenges, { insertHints, insertHintUrls, insertHintSnippets, ctfKey, countryMapping, vulnSnippets }) {
          const fbctfTemplate = await loadTemplate()
        
          fbctfTemplate.teams.teams.push(await createDummyUser())
        
        
        Severity: Minor
        Found in lib/generators/fbctf.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language